[GitHub] [sling-org-apache-sling-testing-osgi-mock] kwin commented on a change in pull request #10: SLING-10919 fix generating component/service properties for DS

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/10#discussion_r748900718



##########
File path: core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java
##########
@@ -122,8 +122,8 @@ public ServiceRegistration registerService(final String clazz, final Object serv
     @SuppressWarnings("unchecked")
     @Override
     public ServiceRegistration registerService(final String[] clazzes, final Object service, final Dictionary properties) {
-        Dictionary<String, Object> mergedPropertes = MapMergeUtil.propertiesMergeWithOsgiMetadata(service.getClass(), configAdmin, properties);
-        MockServiceRegistration<?> registration = new MockServiceRegistration<>(this.bundle, clazzes, service, mergedPropertes, this);
+        ///Dictionary<String, Object> mergedPropertes = MapMergeUtil.propertiesMergeWithOsgiMetadata(service.getClass(), configAdmin, properties);

Review comment:
       this should IMHO not evaluate DS meta data nor config admin...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org