You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/09/19 23:37:08 UTC

[kudu-CR] [transactions] fix compilation warning in tests

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14268


Change subject: [transactions] fix compilation warning in tests
......................................................................

[transactions] fix compilation warning in tests

Fixed compilation warning in transaction_tracker-test.cc:

src/kudu/tablet/transactions/transaction_tracker-test.cc:83:37: \
    warning: 'state' overrides a member function \
    but is not marked 'override'

I also modernized a bit the code around:
  'OVERRIDE' macro --> 'override' keyword

This patch does not contain any functional changes.

Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
---
M src/kudu/tablet/transactions/transaction_tracker-test.cc
1 file changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/14268/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
Gerrit-Change-Number: 14268
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [transactions] fix compilation warning in tests

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14268

to look at the new patch set (#2).

Change subject: [transactions] fix compilation warning in tests
......................................................................

[transactions] fix compilation warning in tests

Fixed compilation warning in transaction_tracker-test.cc:

src/kudu/tablet/transactions/transaction_tracker-test.cc:83:37: \
    warning: 'state' overrides a member function \
    but is not marked 'override'

I also modernized a bit the code around:
  'OVERRIDE' macro --> 'override' keyword

This patch does not contain any functional changes.

Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
---
M src/kudu/tablet/transactions/transaction_tracker-test.cc
1 file changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/14268/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
Gerrit-Change-Number: 14268
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [transactions] fix compilation warning in tests

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14268 )

Change subject: [transactions] fix compilation warning in tests
......................................................................

[transactions] fix compilation warning in tests

Fixed compilation warning in transaction_tracker-test.cc:

src/kudu/tablet/transactions/transaction_tracker-test.cc:83:37: \
    warning: 'state' overrides a member function \
    but is not marked 'override'

I also modernized a bit the code around:
  'OVERRIDE' macro --> 'override' keyword

This patch does not contain any functional changes.

Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
Reviewed-on: http://gerrit.cloudera.org:8080/14268
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tablet/transactions/transaction_tracker-test.cc
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
Gerrit-Change-Number: 14268
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR] [transactions] fix compilation warning in tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14268 )

Change subject: [transactions] fix compilation warning in tests
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie838d6f9ac06b7be94198e33e510fa14bfcf2e13
Gerrit-Change-Number: 14268
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 04:00:00 +0000
Gerrit-HasComments: No