You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/25 07:59:56 UTC

[GitHub] [skywalking] xiaoy00 opened a new pull request #3715: [plugin]support log4j2 AsyncLogger

xiaoy00 opened a new pull request #3715: [plugin]support log4j2 AsyncLogger
URL: https://github.com/apache/skywalking/pull/3715
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [1 ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   there are 2 ways to implement Async log. but now this plugin just 1. so if i use Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector
   to set async log . it doesn't work.
   
   - How to fix?
   intercept RingBufferLogEvent.setMessage(), i can get traceId,then its ok.
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services