[GitHub] [spark] Ngone51 commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #28517:
URL: https://github.com/apache/spark/pull/28517#discussion_r425546566



##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -40,7 +40,7 @@ CREATE TABLE [ IF NOT EXISTS ] table_identifier
     [ AS select_statement ]
 ```
 
-Note that, the clauses between the USING clause and the AS SELECT clause can come in
+Note that, the clauses between the OPTIONS clause and the AS SELECT clause can come in

Review comment:
       Should still be `USING` since `OPTIONS` itself can also come in any order?

##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2195,22 +2195,4 @@ class DDLParserSuite extends AnalysisTest {
       parsePlan("COMMENT ON TABLE a.b.c IS 'xYz'"),
       CommentOnTable(UnresolvedTable(Seq("a", "b", "c")), "xYz"))
   }
-
-  test("create table - without using") {

Review comment:
       So, just remove the conf after revert?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org