[GitHub] [spark] srowen commented on a change in pull request #26334: [SPARK-29675][SQL] Add exception when isolationLevel is Illegal

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #26334: [SPARK-29675][SQL] Add exception when isolationLevel is Illegal
URL: https://github.com/apache/spark/pull/26334#discussion_r341226620
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
 ##########
 @@ -177,6 +177,10 @@ class JDBCOptions(
       case "READ_COMMITTED" => Connection.TRANSACTION_READ_COMMITTED
       case "REPEATABLE_READ" => Connection.TRANSACTION_REPEATABLE_READ
       case "SERIALIZABLE" => Connection.TRANSACTION_SERIALIZABLE
+      case other => throw new IllegalArgumentException(
+        s"Invalid value `$other` for parameter `$JDBC_TXN_ISOLATION_LEVEL`. This can be " +
 
 Review comment:
   Nit: back-ticks aren't meaningful here right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org