You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2019/02/25 23:28:42 UTC

[GitHub] [geode] bschuchardt opened pull request #3234: GEODE-6451 CI Failure: Hang cleaning up after ClusterConfigLocatorRes…

…tartDUnitTest.serverRestartsAfterLocatorReconnects

Removed code that scrubbed the current membership view of IDs matching a
new join request.  This code is no longer needed now that we generate a
new UUID for a member when it tries to auto-reconnect.  The new ID of
such a member would never match an old ID.

In practice this code was causing test failures in situations where the
auto-reconnect time was set to a small value.  A member would end up
sending multiple join requests to the same coordinator.  The first would
be used to allow the new member into the cluster but the second, due to
this code, would cause that member to be immediately removed from the
cluster.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3234 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #3234: GEODE-6451 CI Failure: Hang cleaning up after ClusterConfigLocatorRes…

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
oh, just noticed that this will be removed before merging. Disregard that.

[ Full content available at: https://github.com/apache/geode/pull/3234 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on issue #3234: GEODE-6451 CI Failure: Hang cleaning up after ClusterConfigLocatorRes…

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
Pushing changes for GEODE-5676 to be tested here.  Log messages starting with "BRUCE:" will be removed before merging to develop.

[ Full content available at: https://github.com/apache/geode/pull/3234 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #3234: GEODE-6451 CI Failure: Hang cleaning up after ClusterConfigLocatorRes…

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
is this a fatal message or just a debug message? 

[ Full content available at: https://github.com/apache/geode/pull/3234 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #3234: GEODE-6451 CI Failure: Hang cleaning up after ClusterConfigLocatorRes…

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
[ pull request closed by bschuchardt ]

[ Full content available at: https://github.com/apache/geode/pull/3234 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org