You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/13 09:54:38 UTC
Review Request 55489: Used CMake to generate the compilation database
instead.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
See summary.
Diffs
-----
support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
Diff: https://reviews.apache.org/r/55489/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55489: Used CMake to generate the compilation
database instead.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/#review161662
-----------------------------------------------------------
Ship it!
- Benjamin Bannier
On Jan. 14, 2017, 9:01 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55489/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2017, 9:01 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used CMake to generate the compilation database instead.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
> support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
>
> Diff: https://reviews.apache.org/r/55489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55489: Used CMake to generate the compilation
database instead.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/
-----------------------------------------------------------
(Updated Jan. 14, 2017, 12:01 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments.
Repository: mesos
Description
-------
Used CMake to generate the compilation database instead.
Diffs (updated)
-----
support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
Diff: https://reviews.apache.org/r/55489/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55489: Used CMake to generate the compilation
database instead.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 13, 2017, 1 p.m., Benjamin Bannier wrote:
> > support/mesos-tidy/entrypoint.sh, line 27
> > <https://reviews.apache.org/r/55489/diff/2/?file=1604531#file1604531line27>
> >
> > Left over debug tooling?
>
> Michael Park wrote:
> I use this a bunch of times below.
I think we should either make this accessible to callers by passing in the values via `mesos-tidy.sh` (like is done for e.g., `CHECKS`), or just directly use `$(nproc)`. As currently written the variable provides no direct benefit (but maybe for occasional debugging where one might set `NPROC` to so value by patching this file).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/#review161500
-----------------------------------------------------------
On Jan. 13, 2017, 10:59 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55489/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 10:59 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used CMake to generate the compilation database instead.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
> support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
>
> Diff: https://reviews.apache.org/r/55489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55489: Used CMake to generate the compilation
database instead.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote:
> > support/mesos-tidy.sh, line 19
> > <https://reviews.apache.org/r/55489/diff/2/?file=1604529#file1604529line19>
> >
> > Should we also set `pipefail`?
I didn't know about that. Sounds great.
> On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote:
> > support/mesos-tidy.sh, line 34
> > <https://reviews.apache.org/r/55489/diff/2/?file=1604529#file1604529line34>
> >
> > It seems something like this would still be useful for the cmake build so callers could pass extra configuration flags (e.g., of the form `-DENABLE_DEBUG=ON`).
I'll add this back.
> On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote:
> > support/mesos-tidy/entrypoint.sh, line 27
> > <https://reviews.apache.org/r/55489/diff/2/?file=1604531#file1604531line27>
> >
> > Left over debug tooling?
I use this a bunch of times below.
> On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote:
> > support/mesos-tidy/entrypoint.sh, line 33
> > <https://reviews.apache.org/r/55489/diff/2/?file=1604531#file1604531line33>
> >
> > I don't think the folks interested in cmake would ever see this comment here. We should create tickets and link them here.
Created MESOS-6924 and MESOS-6925
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/#review161500
-----------------------------------------------------------
On Jan. 13, 2017, 1:59 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55489/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 1:59 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used CMake to generate the compilation database instead.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
> support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
>
> Diff: https://reviews.apache.org/r/55489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55489: Used CMake to generate the compilation
database instead.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/#review161500
-----------------------------------------------------------
support/mesos-tidy.sh (line 19)
<https://reviews.apache.org/r/55489/#comment232803>
Should we also set `pipefail`?
support/mesos-tidy.sh
<https://reviews.apache.org/r/55489/#comment232804>
It seems something like this would still be useful for the cmake build so callers could pass extra configuration flags (e.g., of the form `-DENABLE_DEBUG=ON`).
support/mesos-tidy/entrypoint.sh (line 19)
<https://reviews.apache.org/r/55489/#comment232802>
Should we also set `pipefail`?
support/mesos-tidy/entrypoint.sh (line 27)
<https://reviews.apache.org/r/55489/#comment232807>
Left over debug tooling?
support/mesos-tidy/entrypoint.sh (line 33)
<https://reviews.apache.org/r/55489/#comment232805>
I don't think the folks interested in cmake would ever see this comment here. We should create tickets and link them here.
support/mesos-tidy/entrypoint.sh (line 47)
<https://reviews.apache.org/r/55489/#comment232806>
Dito.
- Benjamin Bannier
On Jan. 13, 2017, 10:59 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55489/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 10:59 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used CMake to generate the compilation database instead.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
> support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
>
> Diff: https://reviews.apache.org/r/55489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55489: Used CMake to generate the compilation
database instead.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 1:59 a.m.)
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description (updated)
-------
Used CMake to generate the compilation database instead.
Diffs (updated)
-----
support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
Diff: https://reviews.apache.org/r/55489/diff/
Testing
-------
Thanks,
Michael Park