You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 03:32:09 UTC

[GitHub] [airflow] utkarsharma2 opened a new pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

utkarsharma2 opened a new pull request #21630:
URL: https://github.com/apache/airflow/pull/21630


   related: #21597
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810846748



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -112,8 +112,20 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+        ...
+
+    @overload
     def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
-        """Get a set of records from Presto"""
+        ...

Review comment:
       Static checks were failing on local(MyPy) - Single overload definition, multiple required.
   
   And the workaround I found was to have two different signatures in two @overload signatures. And the actual function header for the implementation should be empty.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810880806



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       Also, I think the idea here is to have the most loose signature in actual implementation like args and kwargs or union of them. 
   So, below should be the code of actual implementation :
   `def get_records(self, sql: str = "", parameters: Optional[dict] = None, **kargs)`
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810884873



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...

Review comment:
       Made the changes. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810835682



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -112,8 +112,20 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+        ...

Review comment:
       ```suggestion
           """Get a set of records from Presto.
   
           :param sql: SQL statement to be executed.
           :param parameters: The parameters to render the SQL query with.
           """
   ```
   
   One blank line after the first line in the docstring. (See [PEP 257](https://www.python.org/dev/peps/pep-0257/))
   
   The `...` part is only needed so the function is not empty, but we already have a docstring here and don’t need it.

##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -112,8 +112,20 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+        ...
+
+    @overload
     def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
-        """Get a set of records from Presto"""
+        ...

Review comment:
       What does this overload do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#issuecomment-1045973405


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810858737



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...

Review comment:
       This should either have a docstring explaining `hql` is deprecated, or a `:sphinx-autoapi-skip:` so it’s hidden in documentation altogether.
   
   Personally I think we can skip it; since the `hql` and `sql` arguments are exactly the same, we don’t need to show the old signature in documentation. People should use the new `sql` argument, and if they are using the old one right now, well, they already know it exists and does not need documentation.

##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       ```suggestion
       def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
   ```
   
   This does not need to change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810876769



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       I can change that but the second overload and the actual implementation will then have the same signature, it can be confusing?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal merged pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #21630:
URL: https://github.com/apache/airflow/pull/21630


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810833262



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,51 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
         """Get a set of records from Presto"""
+        if hql:
+            warnings.warn(
+                "The hql parameter has been deprecated. You should pass the sql parameter.",
+                DeprecationWarning,
+                stacklevel=2,
+            )
+            sql = hql
+
         try:
-            return super().get_records(self._strip_sql(hql), parameters)
+            return super().get_records(self._strip_sql(sql), parameters)
         except DatabaseError as e:
             raise PrestoException(e)
 
-    def get_first(self, hql: str, parameters: Optional[dict] = None) -> Any:
+    def get_first(self, sql: str = "", parameters: Optional[dict] = None, hql: str = "") -> Any:

Review comment:
       @uranusjr, made the required changes please take a look. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810876769



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       I can change that but the second overload and the actual implementation will have the same signature, it can be confusing?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810964044



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       Sure, I'll make update the PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810964044



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       Sure, I'll update the PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#issuecomment-1046006526


   @eladkal, last commit was missing logic to give warning when 'hql' parameter is used, fixed it and static check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#issuecomment-1043403470


   There are 0 files changed.. probably unsuccessful rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810689785



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,51 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
         """Get a set of records from Presto"""
+        if hql:
+            warnings.warn(
+                "The hql parameter has been deprecated. You should pass the sql parameter.",
+                DeprecationWarning,
+                stacklevel=2,
+            )
+            sql = hql
+
         try:
-            return super().get_records(self._strip_sql(hql), parameters)
+            return super().get_records(self._strip_sql(sql), parameters)
         except DatabaseError as e:
             raise PrestoException(e)
 
-    def get_first(self, hql: str, parameters: Optional[dict] = None) -> Any:
+    def get_first(self, sql: str = "", parameters: Optional[dict] = None, hql: str = "") -> Any:

Review comment:
       Can you add some `@overload` signatures and markers so `hql` does not show up in documentation? (Especially not _together_ with `sql` so users don’t get confused with the two.)
   
   Something like
   
   ```python
   @overload
   def get_first(self, sql: str, parameters: Optional[dict] = None) -> Any:
       """Return only the first row, regardless of how many rows the query returns.
   
       :param sql: SQL string to execute.
       :param parameters: Something something
       """
       ...
   
   def get_first(self, sql: str = "", parameters: Optional[dict] = None, hql: str = "") -> Any:
       """:sphinx-autoapi-skip:"""
       # Actual implementation...
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810956183



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -111,27 +112,87 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
-    def get_records(self, hql, parameters: Optional[dict] = None):
-        """Get a set of records from Presto"""
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql: str = ""):
+        ...
+
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None, hql=None):

Review comment:
       The two are used for different purposes; the overload is only used by Mypy, and the actual implementation is only used at runtime. So having them match is not a problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810857017



##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -112,8 +112,20 @@ def get_isolation_level(self) -> Any:
     def _strip_sql(sql: str) -> str:
         return sql.strip().rstrip(';')
 
+    @overload
+    def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+        """Get a set of records from Presto
+        :param sql: SQL statement to be executed.
+        :param parameters: The parameters to render the SQL query with.
+        """
+        ...

Review comment:
       Made changes to docstring and also removed `...`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org