[incubator-plc4x] branch master updated: - Increasing the coverage of the field items

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new 809d96a  - Increasing the coverage of the field items
809d96a is described below

commit 809d96a547701c09404e2b8968afa5450ecbd585
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Sat Nov 10 18:43:22 2018 +0100

    - Increasing the coverage of the field items
---
 .../plc4x/java/base/messages/items/BaseDefaultFieldItem.java       | 2 +-
 .../apache/plc4x/java/base/messages/items/DefaultItemsSpec.groovy  | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/items/BaseDefaultFieldItem.java b/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/items/BaseDefaultFieldItem.java
index 3317dd1..4abcda5 100644
--- a/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/items/BaseDefaultFieldItem.java
+++ b/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/items/BaseDefaultFieldItem.java
@@ -31,7 +31,7 @@ import java.util.Objects;
 
 public abstract class BaseDefaultFieldItem<T> {
 
-    private T[] values;
+    private final T[] values;
 
     protected BaseDefaultFieldItem(T[] values) {
         this.values = Objects.requireNonNull(values);
diff --git a/plc4j/protocols/driver-bases/base/src/test/groovy/org/apache/plc4x/java/base/messages/items/DefaultItemsSpec.groovy b/plc4j/protocols/driver-bases/base/src/test/groovy/org/apache/plc4x/java/base/messages/items/DefaultItemsSpec.groovy
index 32a7edf..bc051ff 100644
--- a/plc4j/protocols/driver-bases/base/src/test/groovy/org/apache/plc4x/java/base/messages/items/DefaultItemsSpec.groovy
+++ b/plc4j/protocols/driver-bases/base/src/test/groovy/org/apache/plc4x/java/base/messages/items/DefaultItemsSpec.groovy
@@ -18,7 +18,9 @@
  */
 package org.apache.plc4x.java.base.messages.items
 
-
+import nl.jqno.equalsverifier.EqualsVerifier
+import nl.jqno.equalsverifier.Warning
+import org.apache.commons.lang3.StringUtils
 import org.apache.plc4x.java.api.exceptions.PlcIncompatibleDatatypeException
 import spock.lang.Specification
 import spock.lang.Unroll
@@ -55,6 +57,8 @@ class DefaultItemsSpec extends Specification {
         assertItem(fieldItem, "Date", isValidDate)
         assertItem(fieldItem, "DateTime", isValidDateTime)
         assertItem(fieldItem, "ByteArray", isValidByteArray)
+        EqualsVerifier.forClass(fieldItemType).suppress(Warning.STRICT_INHERITANCE).verify()
+        assert StringUtils.isNotBlank(fieldItem.toString())
 
         where:
         fieldItemType                 | value                                          || isValidBoolean | isValidByte | isValidShort | isValidInteger | isValidLong | isValidBigInteger | isValidFloat | isValidDouble | isValidBigDecimal | isValidString | isValidTime | isValidDate | isValidDateTime | isValidByteArray
@@ -186,6 +190,7 @@ class DefaultItemsSpec extends Specification {
         } else {
             assert getExecutionException({ fieldItem."get$type"(0) }) instanceof PlcIncompatibleDatatypeException
         }
+        getExecutionException({ fieldItem."get$type"(42) }) instanceof PlcIncompatibleDatatypeException
         return true
     }