[GitHub] [celix] pnoltes commented on pull request #328: Fixes pubsub scope issue

[GitBox <gi...@apache.org>]

pnoltes commented on pull request #328:
URL: https://github.com/apache/celix/pull/328#issuecomment-790000812


   > This would mean that a filter like `(topic=t)(scope=*)` would be marked as not having a scope. This would then filter for any pubsub channel that also has no scope marked but ignoring any pubsub channel that does have a scope.
   > 
   > I'm unsure if this behaviour is desired.
   
   Yes a service dependency with a `(topic=t)(scope=*)` filter will result in a publisher with no scope property. The dependency will match all publisher with topic=t and a scope, but not the publisher just registered.
   
   I am also not sure if the behavior is desired. I am leaning towards making topic and scope mandatory (for requesting publishers and providing subscriber) again. This was a far more simpler to handle and less error prone. 
   
   But reverting this behavior is also impactful, especially to align on endpoint discovery between Java and C.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org