You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/05 16:55:08 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #14107: Restores flexible installation version, fixes manual tag build process.

kaxil commented on a change in pull request #14107:
URL: https://github.com/apache/airflow/pull/14107#discussion_r571108941



##########
File path: scripts/ci/images/ci_build_dockerhub.sh
##########
@@ -113,7 +113,7 @@ else
     export DOCKER_CACHE="local"
     # Name the image based on the TAG rather than based on the branch name
     export FORCE_AIRFLOW_PROD_BASE_TAG="${DOCKER_TAG}"
-    export INSTALL_AIRFLOW_VERSION="${DOCKER_TAG%-python*}"
+    export INSTALL_AIRFLOW_VERSION="==${DOCKER_TAG%-python*}"

Review comment:
       The line below now fails

##########
File path: scripts/ci/images/ci_build_dockerhub.sh
##########
@@ -113,7 +113,7 @@ else
     export DOCKER_CACHE="local"
     # Name the image based on the TAG rather than based on the branch name
     export FORCE_AIRFLOW_PROD_BASE_TAG="${DOCKER_TAG}"
-    export INSTALL_AIRFLOW_VERSION="${DOCKER_TAG%-python*}"
+    export INSTALL_AIRFLOW_VERSION="==${DOCKER_TAG%-python*}"

Review comment:
       ```
   export AIRFLOW_CONSTRAINTS_REFERENCE="constraints-${INSTALL_AIRFLOW_VERSION}"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org