You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Anita Kulshreshtha (JIRA)" <ji...@apache.org> on 2006/11/30 18:20:22 UTC
[jira] Created: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
GoperationInfo should include the return type for the operation
----------------------------------------------------------------
Key: GERONIMO-2607
URL: http://issues.apache.org/jira/browse/GERONIMO-2607
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: kernel
Affects Versions: 2.0
Environment: All
Reporter: Anita Kulshreshtha
Assigned To: Anita Kulshreshtha
When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462669 ]
Anita Kulshreshtha commented on GERONIMO-2607:
----------------------------------------------
>From a discussion on the mailing list:
http://www.nabble.com/Re%3A-svn-commit%3A-r485321---in--geronimo-server-trunk-modules%3A-geronimo-kernel-src-main-java-org-apache-geronimo-gbean--geronimo-kernel-src-main-java-org-apache-geronimo-gbean-runtime--geronimo-kernel-src-test-java-org-apache-geronimo-gbean--geronimo-k-p7857544.html
The kernel.diff patch:
1. deprecates addOperation(..) methods from GBeanInfoBuilder. These are redundant because the operations added by these methods were already being added by addInterface(..).
A side effect of this is that non-existent or inconsistent operations can not be added.
2. Makes the new addOpearation methods (added in rev 485321) private
3. updates GBeanInfoTest
These changes are sufficient to provide a return type for operations to JMX tools.
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: https://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2607?page=comments#action_12457216 ]
Anita Kulshreshtha commented on GERONIMO-2607:
----------------------------------------------
Fixed in rev 485321
TODO - Update all GBeans to use the new GBeanInfoBuilder.addOpeartion(...) methods
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: http://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2607?page=all ]
Anita Kulshreshtha updated GERONIMO-2607:
-----------------------------------------
Attachment: kernel.diff
I am attaching a patch for initial feedback. Are there any objections to this kind of modification? The changes are working. In addtion to this the tests need to be fixed to not use the old classes. Is there a better way of accomplishing the same?
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: http://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2607?page=all ]
Anita Kulshreshtha updated GERONIMO-2607:
-----------------------------------------
Attachment: modules.diff
The modules.diff patch adds two methods to GBeanInfoBuilder:
public void addOperation(String name, String returnType)
public void addOperation(String name, Class[] paramTypes, String returnType)
and deprecates
public void addOperation(String name)
public void addOperation(String name, Class[] paramTypes)
If there are no objections, I will commit this patch in 24 hours
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: http://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anita Kulshreshtha closed GERONIMO-2607.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0
Fixed in rev 558235
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: https://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M2
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Anita Kulshreshtha
> Fix For: 2.0
>
> Attachments: kernel.diff, kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514836 ]
Anita Kulshreshtha commented on GERONIMO-2607:
----------------------------------------------
Reapplied rev 499201. As before all operations except getters/setters are added automatically to GBeanInfo. The getters/setters must be added explicitly using addOperation.
http://www.nabble.com/GBeanInfoBuilder--was-Re%3A-svn-commit%3A-r499201---in--geronimo-server-trunk-modules-geronimo-kernel-src%3A-main-java-org-apache-geronimo-gbean--main-java-org-apache-geronimo-gbean-runtime--test-java-org-apache-geronimo-gbean--p10980263s134.html
Thanks Matt for deploying SNAPSHOTs.
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: https://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M2
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Anita Kulshreshtha
> Attachments: kernel.diff, kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2607?page=comments#action_12457239 ]
Anita Kulshreshtha commented on GERONIMO-2607:
----------------------------------------------
Updated all GBeans to use the new addOperation method in rev 485524
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: http://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Hogstrom updated GERONIMO-2607:
------------------------------------
Affects Version/s: (was: 2.0)
2.0-M2
Applied kernel patch for Anita and deployed a new SNAPSHOT.
Anita, please close if your satisfied.
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: https://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M2
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2607?page=all ]
Anita Kulshreshtha updated GERONIMO-2607:
-----------------------------------------
Attachment: operations.jpg
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: http://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2607) GoperationInfo should include the
return type for the operation
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anita Kulshreshtha updated GERONIMO-2607:
-----------------------------------------
Attachment: kernel.diff
> GoperationInfo should include the return type for the operation
> ---------------------------------------------------------------
>
> Key: GERONIMO-2607
> URL: https://issues.apache.org/jira/browse/GERONIMO-2607
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Anita Kulshreshtha
> Attachments: kernel.diff, kernel.diff, modules.diff, operations.jpg
>
>
> When the operations are viewed by jconsole the return type is not avaialble. GOpeartionInfo should keep the retrunType information.
> This will break backward compatibility of GBeanInfo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira