[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #168: [FLINK-28179] LeafPredicate accepts multiple literals

[GitBox <gi...@apache.org>]

LadyForest commented on code in PR #168:
URL: https://github.com/apache/flink-table-store/pull/168#discussion_r903225265


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/LeafPredicate.java:
##########
@@ -18,70 +18,107 @@
 
 package org.apache.flink.table.store.file.predicate;
 
+import org.apache.flink.api.common.typeutils.base.ListSerializer;
+import org.apache.flink.api.java.typeutils.runtime.NullableSerializer;
+import org.apache.flink.core.memory.DataInputViewStreamWrapper;
+import org.apache.flink.core.memory.DataOutputViewStreamWrapper;
+import org.apache.flink.table.runtime.typeutils.InternalSerializers;
 import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.types.logical.LogicalType;
 
-import java.io.Serializable;
+import javax.annotation.Nullable;
+
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
 
 /** Leaf node of a {@link Predicate} tree. Compares a field in the row with an {@link Literal}. */

Review Comment:
   ```suggestion
   /** Leaf node of a {@link Predicate} tree. Compares a field in the row with an {@link Literal}. */
   ```
   ```suggestion
   /** Leaf node of a {@link Predicate} tree. Compares a field in the row with literals. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org