[GitHub] [skywalking] arugal commented on a change in pull request #4509: SkyWalking Cross Process Correlation Headers Protocol

[GitBox <gi...@apache.org>]

arugal commented on a change in pull request #4509: SkyWalking Cross Process Correlation Headers Protocol
URL: https://github.com/apache/skywalking/pull/4509#discussion_r392588153
 
 

 ##########
 File path: docs/en/protocols/Skywalking-Cross-Process-Correlation-Headers-Protocol-v1.md
 ##########
 @@ -0,0 +1,16 @@
+# SkyWalking Cross Process Correlation Headers Protocol
+* Version 1.0
+
+The Cross Process Correlation Headers Protocol is used to transport custom data by leveraging the capability of [Cross Process Propagation Headers Protocol](Skywalking-Cross-Process-Propagation-Headers-Protocol-v2.md). 
+
+This is an optional and additional protocol for language tracer implementation. All tracer implementation could consider to implement this.
+Cross Process Correlation Header key is `sw7-correlation`. The value is the `encoded(key):encoded(value)` list with elements splitted by `,` such as `base64(string key):base64(string value),base64(string key2):base64(string value2)`.
+
+## Recommendations of language APIs
+Recommended implementation in different language API.
+
+1. `CorrelationContext#set` and `CorrelationContext#get` are recommended to write and read the correlation context, with key/value string.
+1. The key should be added if it is absent.
+1. The later writes should override the previous value.
+1. The total number of all keys should be less than 3, and the length of each value should be less than 128 bytes.
+1. The context should be propagated as well when tracing context is propagated across threads and processes..
 
 Review comment:
   ```suggestion
   1. The context should be propagated as well when tracing context is propagated across threads and processes.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services