[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #5938: Move error check from pipeline fixer to pipeline checker

["ozankabak (via GitHub)" <gi...@apache.org>]

ozankabak commented on code in PR #5938:
URL: https://github.com/apache/arrow-datafusion/pull/5938#discussion_r1161899802


##########
datafusion/core/src/physical_optimizer/pipeline_checker.rs:
##########
@@ -314,7 +314,7 @@ mod sql_tests {
                   FROM test
                   LIMIT 5".to_string(),
             cases: vec![Arc::new(test1), Arc::new(test2)],
-            error_operator: "Window Error".to_string()
+            error_operator: "Sort Error".to_string()

Review Comment:
   I think this happens because when the task of erroring out is left to `PipelineChecker`, which is the last rule, sorts are already in-place. While checking, the algorithm first encounters the sort (before the window), which is is pipeline-breaking. Hence the error messsage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org