[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #43: More polishing, add a link for each migrated comment back to the 'final inch' comment in Jira

[GitBox <gi...@apache.org>]

mocobeta commented on code in PR #43:
URL: https://github.com/apache/lucene-jira-archive/pull/43#discussion_r920069683


##########
migration/src/jira2github_import.py:
##########
@@ -146,8 +146,10 @@ def comment_author(author_name, author_dispname):
                 logger.error(f"Failed to convert comment on {jira_issue_id(num)} due to above exception ({str(e)}); falling back to original Jira comment as code block.")
                 logger.error(f"Original text: {comment_body}")
                 comment_body = f"```\n{comment_body}```\n\n"
+
+            jira_comment_link = f'https://issues.apache.org/jira/browse/{jira_id}?focusedCommentId={comment_id}&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-{comment_id}'

Review Comment:
   This is fine with me. I actually once thought the same thing, was not confident if this link is "permanent"...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org