You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2016/11/02 23:17:28 UTC
Fwd: [2/2] commons-dbcp git commit: Fix DBCP-472
You beat me to it! Too busy at work...
Are you avail to RM a release train for Pool and DBCP?
Gary
---------- Forwarded message ----------
From: <ma...@apache.org>
Date: Nov 2, 2016 2:26 PM
Subject: [2/2] commons-dbcp git commit: Fix DBCP-472
To: <co...@commons.apache.org>
Cc:
Fix DBCP-472
>
> Avoid potential infinite loops when checking if an SQLException is fatal
> for a connection or not.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/
> 0b5b1be8
> Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/0b5b1be8
> Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/0b5b1be8
>
> Branch: refs/heads/master
> Commit: 0b5b1be810baf881d835ef2a96d55f54f537a6a5
> Parents: a204265
> Author: Mark Thomas <ma...@apache.org>
> Authored: Wed Nov 2 21:24:45 2016 +0000
> Committer: Mark Thomas <ma...@apache.org>
> Committed: Wed Nov 2 21:24:45 2016 +0000
>
> ----------------------------------------------------------------------
> src/changes/changes.xml | 4 ++++
> src/main/java/org/apache/commons/dbcp2/PoolableConnection.java | 3 ++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/
> 0b5b1be8/src/changes/changes.xml
> ----------------------------------------------------------------------
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index 72d368d..c03667c 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -95,6 +95,10 @@ The <action> type attribute can be
> add,update,fix,remove.
> Correct the name of the configuration attribute
> softMinEvictableIdleTimeMillis.
> </action>
> + <action dev="markt" type="fix" issue="DBCP-472">
> + Avoid potential infinite loops when checking if an SQLException
> is fatal
> + for a connection or not.
> + </action>
> </release>
> <release version="2.1.1" date="6 Aug 2015" description=
> "This is a patch release, including bug fixes only.">
>
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/
> 0b5b1be8/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> ----------------------------------------------------------------------
> diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> index 2773f4f..7424240 100644
> --- a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> +++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> @@ -326,7 +326,8 @@ public class PoolableConnection extends
> DelegatingConnection<Connection>
> fatalException = _disconnectionSqlCodes == null ?
> sqlState.startsWith(Utils.DISCONNECTION_SQL_CODE_PREFIX)
> || Utils.DISCONNECTION_SQL_CODES.contains(sqlState)
> : _disconnectionSqlCodes.contains(sqlState);
> if (!fatalException) {
> - if (e.getNextException() != null) {
> + SQLException nextException = e.getNextException();
> + if (nextException != null && nextException != e) {
> fatalException = isDisconnectionSqlException(e.
> getNextException());
> }
> }
>
>
Re: Fwd: [2/2] commons-dbcp git commit: Fix DBCP-472
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 3, 2016 at 2:22 AM, Mark Thomas <ma...@apache.org> wrote:
> On 02/11/2016 23:17, Gary Gregory wrote:
> > You beat me to it! Too busy at work...
> >
> > Are you avail to RM a release train for Pool and DBCP?
>
> Not sure. While I haven't got to looking at the bugs yet, Daemon is
> going to be my priority for a release.
>
That sounds GREAT. Commons Daemon is overdue for a release.
Gary
>
> Mark
>
> >
> > Gary
> > ---------- Forwarded message ----------
> > From: <ma...@apache.org>
> > Date: Nov 2, 2016 2:26 PM
> > Subject: [2/2] commons-dbcp git commit: Fix DBCP-472
> > To: <co...@commons.apache.org>
> > Cc:
> >
> > Fix DBCP-472
> >>
> >> Avoid potential infinite loops when checking if an SQLException is fatal
> >> for a connection or not.
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/
> >> 0b5b1be8
> >> Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/0b5b1be8
> >> Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/0b5b1be8
> >>
> >> Branch: refs/heads/master
> >> Commit: 0b5b1be810baf881d835ef2a96d55f54f537a6a5
> >> Parents: a204265
> >> Author: Mark Thomas <ma...@apache.org>
> >> Authored: Wed Nov 2 21:24:45 2016 +0000
> >> Committer: Mark Thomas <ma...@apache.org>
> >> Committed: Wed Nov 2 21:24:45 2016 +0000
> >>
> >> ----------------------------------------------------------------------
> >> src/changes/changes.xml | 4 ++++
> >> src/main/java/org/apache/commons/dbcp2/PoolableConnection.java | 3 ++-
> >> 2 files changed, 6 insertions(+), 1 deletion(-)
> >> ----------------------------------------------------------------------
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/
> >> 0b5b1be8/src/changes/changes.xml
> >> ----------------------------------------------------------------------
> >> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> >> index 72d368d..c03667c 100644
> >> --- a/src/changes/changes.xml
> >> +++ b/src/changes/changes.xml
> >> @@ -95,6 +95,10 @@ The <action> type attribute can be
> >> add,update,fix,remove.
> >> Correct the name of the configuration attribute
> >> softMinEvictableIdleTimeMillis.
> >> </action>
> >> + <action dev="markt" type="fix" issue="DBCP-472">
> >> + Avoid potential infinite loops when checking if an SQLException
> >> is fatal
> >> + for a connection or not.
> >> + </action>
> >> </release>
> >> <release version="2.1.1" date="6 Aug 2015" description=
> >> "This is a patch release, including bug fixes only.">
> >>
> >> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/
> >> 0b5b1be8/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> >> ----------------------------------------------------------------------
> >> diff --git a/src/main/java/org/apache/commons/dbcp2/
> PoolableConnection.java
> >> b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> >> index 2773f4f..7424240 100644
> >> --- a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> >> +++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
> >> @@ -326,7 +326,8 @@ public class PoolableConnection extends
> >> DelegatingConnection<Connection>
> >> fatalException = _disconnectionSqlCodes == null ?
> >> sqlState.startsWith(Utils.DISCONNECTION_SQL_CODE_PREFIX)
> >> || Utils.DISCONNECTION_SQL_CODES.
> contains(sqlState)
> >> : _disconnectionSqlCodes.contains(sqlState);
> >> if (!fatalException) {
> >> - if (e.getNextException() != null) {
> >> + SQLException nextException = e.getNextException();
> >> + if (nextException != null && nextException != e) {
> >> fatalException = isDisconnectionSqlException(e.
> >> getNextException());
> >> }
> >> }
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Fwd: [2/2] commons-dbcp git commit: Fix DBCP-472
Posted by Mark Thomas <ma...@apache.org>.
On 02/11/2016 23:17, Gary Gregory wrote:
> You beat me to it! Too busy at work...
>
> Are you avail to RM a release train for Pool and DBCP?
Not sure. While I haven't got to looking at the bugs yet, Daemon is
going to be my priority for a release.
Mark
>
> Gary
> ---------- Forwarded message ----------
> From: <ma...@apache.org>
> Date: Nov 2, 2016 2:26 PM
> Subject: [2/2] commons-dbcp git commit: Fix DBCP-472
> To: <co...@commons.apache.org>
> Cc:
>
> Fix DBCP-472
>>
>> Avoid potential infinite loops when checking if an SQLException is fatal
>> for a connection or not.
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/
>> 0b5b1be8
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/0b5b1be8
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/0b5b1be8
>>
>> Branch: refs/heads/master
>> Commit: 0b5b1be810baf881d835ef2a96d55f54f537a6a5
>> Parents: a204265
>> Author: Mark Thomas <ma...@apache.org>
>> Authored: Wed Nov 2 21:24:45 2016 +0000
>> Committer: Mark Thomas <ma...@apache.org>
>> Committed: Wed Nov 2 21:24:45 2016 +0000
>>
>> ----------------------------------------------------------------------
>> src/changes/changes.xml | 4 ++++
>> src/main/java/org/apache/commons/dbcp2/PoolableConnection.java | 3 ++-
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/
>> 0b5b1be8/src/changes/changes.xml
>> ----------------------------------------------------------------------
>> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
>> index 72d368d..c03667c 100644
>> --- a/src/changes/changes.xml
>> +++ b/src/changes/changes.xml
>> @@ -95,6 +95,10 @@ The <action> type attribute can be
>> add,update,fix,remove.
>> Correct the name of the configuration attribute
>> softMinEvictableIdleTimeMillis.
>> </action>
>> + <action dev="markt" type="fix" issue="DBCP-472">
>> + Avoid potential infinite loops when checking if an SQLException
>> is fatal
>> + for a connection or not.
>> + </action>
>> </release>
>> <release version="2.1.1" date="6 Aug 2015" description=
>> "This is a patch release, including bug fixes only.">
>>
>> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/
>> 0b5b1be8/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
>> ----------------------------------------------------------------------
>> diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
>> b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
>> index 2773f4f..7424240 100644
>> --- a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
>> +++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
>> @@ -326,7 +326,8 @@ public class PoolableConnection extends
>> DelegatingConnection<Connection>
>> fatalException = _disconnectionSqlCodes == null ?
>> sqlState.startsWith(Utils.DISCONNECTION_SQL_CODE_PREFIX)
>> || Utils.DISCONNECTION_SQL_CODES.contains(sqlState)
>> : _disconnectionSqlCodes.contains(sqlState);
>> if (!fatalException) {
>> - if (e.getNextException() != null) {
>> + SQLException nextException = e.getNextException();
>> + if (nextException != null && nextException != e) {
>> fatalException = isDisconnectionSqlException(e.
>> getNextException());
>> }
>> }
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org