You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/11 17:10:07 UTC

[GitHub] [airflow] ashb opened a new pull request #13020: Simplify release process for PyPI snapshots

ashb opened a new pull request #13020:
URL: https://github.com/apache/airflow/pull/13020

Setuptools has a built in mechanism for adding a `suffix` to a version,
so we don't have to edit a file and then remember to delete it!

It's a little bit messy to get the suffix like this -- using sed to
strip out any leading digits or periods, but it's copy-pasteable this
way.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #13020:
URL: https://github.com/apache/airflow/pull/13020#issuecomment-743320395


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

ashb commented on a change in pull request #13020:
URL: https://github.com/apache/airflow/pull/13020#discussion_r541101271



##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -148,12 +148,10 @@ svn commit -m "Add artifacts for Airflow ${VERSION}"
 At this point we have the artefact that we vote on, but as a convenience to developers we also want to
 publish "snapshots" of the RC builds to pypi for installing via pip. To do this we need to
 
-- Edit the `setup.py` to include the RC suffix.
-
 - Build the package:
 
     ```shell script
-    python setup.py compile_assets sdist bdist_wheel
+    python setup.py compile_assets egg_info --tag-build "$(sed -e "s/^[0-9.]*//" <<<"$VERSION")" sdist bdist_wheel

Review comment:
       Both of those use egg_info (technically they use build which uses egg_info)
   
   But yes, I used this for https://pypi.org/project/apache-airflow-upgrade-check/1.1.0rc1/#files




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #13020:
URL: https://github.com/apache/airflow/pull/13020#issuecomment-743336758


   Yep. Confirmed it works for both. I converted provider package to use it as well in #13021


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

ashb commented on a change in pull request #13020:
URL: https://github.com/apache/airflow/pull/13020#discussion_r541101271



##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -148,12 +148,10 @@ svn commit -m "Add artifacts for Airflow ${VERSION}"
 At this point we have the artefact that we vote on, but as a convenience to developers we also want to
 publish "snapshots" of the RC builds to pypi for installing via pip. To do this we need to
 
-- Edit the `setup.py` to include the RC suffix.
-
 - Build the package:
 
     ```shell script
-    python setup.py compile_assets sdist bdist_wheel
+    python setup.py compile_assets egg_info --tag-build "$(sed -e "s/^[0-9.]*//" <<<"$VERSION")" sdist bdist_wheel

Review comment:
       Both of those use egg_info (technically bdist* uses build which uses egg_info)
   
   But yes, I used this for https://pypi.org/project/apache-airflow-upgrade-check/1.1.0rc1/#files




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #13020:
URL: https://github.com/apache/airflow/pull/13020


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #13020:
URL: https://github.com/apache/airflow/pull/13020#discussion_r541105887



##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -148,12 +148,10 @@ svn commit -m "Add artifacts for Airflow ${VERSION}"
 At this point we have the artefact that we vote on, but as a convenience to developers we also want to
 publish "snapshots" of the RC builds to pypi for installing via pip. To do this we need to
 
-- Edit the `setup.py` to include the RC suffix.
-
 - Build the package:
 
     ```shell script
-    python setup.py compile_assets sdist bdist_wheel
+    python setup.py compile_assets egg_info --tag-build "$(sed -e "s/^[0-9.]*//" <<<"$VERSION")" sdist bdist_wheel

Review comment:
       Nice. I might use it in the providers packages as well and get rid of the setup.py "if" I have there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #13020: Simplify release process for PyPI snapshots

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #13020:
URL: https://github.com/apache/airflow/pull/13020#discussion_r541099194



##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -148,12 +148,10 @@ svn commit -m "Add artifacts for Airflow ${VERSION}"
 At this point we have the artefact that we vote on, but as a convenience to developers we also want to
 publish "snapshots" of the RC builds to pypi for installing via pip. To do this we need to
 
-- Edit the `setup.py` to include the RC suffix.
-
 - Build the package:
 
     ```shell script
-    python setup.py compile_assets sdist bdist_wheel
+    python setup.py compile_assets egg_info --tag-build "$(sed -e "s/^[0-9.]*//" <<<"$VERSION")" sdist bdist_wheel

Review comment:
       does `egg_info` take care of both `sdist bdist_wheel` ?
   
   I guess yes but just confirming




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org