You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/12 04:55:51 UTC
[GitHub] [incubator-druid] jihoonson commented on a change in pull request
#6496: Support kafka transactional topics (#5404)
jihoonson commented on a change in pull request #6496: Support kafka transactional topics (#5404)
URL: https://github.com/apache/incubator-druid/pull/6496#discussion_r264521370
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -504,10 +504,11 @@ public void run()
SequenceMetadata sequenceToCheckpoint = null;
for (OrderedPartitionableRecord<PartitionIdType, SequenceOffsetType> record : records) {
+
// for Kafka, the end offsets are exclusive, so skip it
if (isEndSequenceOffsetsExclusive() &&
createSequenceNumber(record.getSequenceNumber()).compareTo(
- createSequenceNumber(endOffsets.get(record.getPartitionId()))) == 0) {
+ createSequenceNumber(endOffsets.get(record.getPartitionId()))) >= 0) {
Review comment:
Is this possible that the sequence number of `record` is larger than the end offset? The end offset must be either `unlimited` or `max(actually consumed offsets of all replicas)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org