You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/05/12 11:50:33 UTC
[GitHub] cordova-lib pull request #557: CB-12787: Fix plugin installation with --link...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/557
CB-12787: Fix plugin installation with --link option
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
all
### What does this PR do?
Fix logic for installation plugins with `--link` option.
- Use `npm link` instead of `npm install` during plugin fetch.
- Find symbolic links in plugin's dir for plugin removal
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib CB-12787
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/557.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #557
----
commit 0eb176af7f6b00984f3d41320a1ff6f7f494928c
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-05-12T11:26:05Z
CB-12787: Fix plugin installation with --link option
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #557: CB-12787: Fix plugin installation with --link option
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/557
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=h1) Report
> Merging [#557](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/3962053f7f5c7c65259f9926a220671595c6d944?src=pr&el=desc) will **increase** coverage by `0.68%`.
> The diff coverage is `90%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 79.48% 80.17% +0.68%
==========================================
Files 57 57
Lines 3944 3950 +6
Branches 828 829 +1
==========================================
+ Hits 3135 3167 +32
+ Misses 809 783 -26
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `96.72% <90%> (-0.34%)` | :arrow_down: |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `75.05% <0%> (+0.47%)` | :arrow_up: |
| [cordova-lib/src/cordova/plugin.js](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGx1Z2luLmpz) | `86.85% <0%> (+1.55%)` | :arrow_up: |
| [cordova-lib/src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz) | `89.76% <0%> (+8.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=footer). Last update [3962053...0eb176a](https://codecov.io/gh/apache/cordova-lib/pull/557?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #557: CB-12787: Fix plugin installation with --link option
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/557
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #557: CB-12787: Fix plugin installation with --link...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org