[jira] [Commented] (HIVE-9182) avoid FileSystem.getAclStatus rpc call for filesystems that don't support acl

["Thejas M Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490218#comment-14490218 ] 

Thejas M Nair commented on HIVE-9182:
-------------------------------------

[~ashettia] The indentation seems to be off and there are some trailing white spaces, can you please update patch to fix that ?

[~cnauroth] {{setFullFileStatus}} already has the ACL permissions (if any) for source file, and is trying to set it for a new file. I don't think the {{fileStatus.getPermission()}} method would work there. Please correct me if I am wrong. 
But the  {{if (isExtendedAclEnabled(conf))}} check in {{setFullFileStatus}}  seems to be flawed as it checks only for HDFS configuration. For example if the two file systems involved are not HDFS and HDFS has ACL disabled, and those two files systems support ACL, new file will not be inheriting the ACL permissions correctly. But I guess that is not a common use case.


> avoid FileSystem.getAclStatus rpc call for filesystems that don't support acl
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-9182
>                 URL: https://issues.apache.org/jira/browse/HIVE-9182
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Thejas M Nair
>            Assignee: Abdelrahman Shettia
>             Fix For: 1.2.0
>
>         Attachments: HIVE-9182.1.patch
>
>
> File systems such as s3, wasp (azure) don't implement Hadoop FileSystem acl functionality.
> Hadoop23Shims has code that calls getAclStatus on file systems.
> Instead of calling getAclStatus and catching the exception, we can also check FsPermission#getAclBit .
> Additionally, instead of catching all exceptions for calls to getAclStatus and ignoring them, it is better to just catch UnsupportedOperationException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)