You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/22 18:49:29 UTC
[GitHub] [spark] dbaliafroozeh opened a new pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
dbaliafroozeh opened a new pull request #31932:
URL: https://github.com/apache/spark/pull/31932
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805121279
**[Test build #136409 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136409/testReport)** for PR 31932 at commit [`b27bb4d`](https://github.com/apache/spark/commit/b27bb4dbd9a3b846f1365e7eb85216d7ef1d4202).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809382482
**[Test build #136655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136655/testReport)** for PR 31932 at commit [`1ac45f5`](https://github.com/apache/spark/commit/1ac45f586802b18bc01a747501e563e45f26ef77).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809382482
**[Test build #136655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136655/testReport)** for PR 31932 at commit [`1ac45f5`](https://github.com/apache/spark/commit/1ac45f586802b18bc01a747501e563e45f26ef77).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31932: [SPARK-34906] Refactor TreeNode's children handling methods into specialized traits
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31932:
URL: https://github.com/apache/spark/pull/31932#discussion_r604633980
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala
##########
@@ -27,9 +28,10 @@ import org.apache.spark.sql.types._
* When applied on empty data (i.e., count is zero), it returns NULL.
*/
abstract class Covariance(x: Expression, y: Expression, nullOnDivideByZero: Boolean)
Review comment:
we can simply do `val left: Expression, val right: Expression` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809384674
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136655/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804383545
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809730494
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41242/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804427663
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809571743
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809819206
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805145190
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804406210
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809730494
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41242/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805150789
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804330798
**[Test build #136360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136360/testReport)** for PR 31932 at commit [`8928cce`](https://github.com/apache/spark/commit/8928cced28fc7116b7cabcf559277264c4c17318).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809394550
**[Test build #136660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136660/testReport)** for PR 31932 at commit [`6e3f54a`](https://github.com/apache/spark/commit/6e3f54a4073b400ba1b0ed082c0f5c8b7e0a6dab).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809384596
**[Test build #136655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136655/testReport)** for PR 31932 at commit [`1ac45f5`](https://github.com/apache/spark/commit/1ac45f586802b18bc01a747501e563e45f26ef77).
* This patch **fails Scala style tests**.
* This patch **does not merge cleanly**.
* This patch adds the following public classes _(experimental)_:
* `case class UseStatement(isNamespaceSet: Boolean, nameParts: Seq[String]) extends LeafParsedStatement`
* `case class ShowCurrentNamespaceStatement() extends LeafParsedStatement`
* `trait V2WriteCommand extends UnaryCommand `
* `trait V2PartitionCommand extends UnaryCommand `
* `case class RefreshTable(child: LogicalPlan) extends UnaryCommand`
* `case class ShowCurrentNamespace(catalogManager: CatalogManager) extends LeafCommand `
* `case class CommentOnNamespace(child: LogicalPlan, comment: String) extends UnaryCommand`
* `case class CommentOnTable(child: LogicalPlan, comment: String) extends UnaryCommand`
* `case class RefreshFunction(child: LogicalPlan) extends UnaryCommand`
* `case class DescribeFunction(child: LogicalPlan, isExtended: Boolean) extends UnaryCommand`
* `case class RecoverPartitions(child: LogicalPlan) extends UnaryCommand`
* `case class TruncateTable(table: LogicalPlan) extends UnaryCommand `
* `trait RunnableCommand extends LeafCommand `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809571743
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804330798
**[Test build #136360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136360/testReport)** for PR 31932 at commit [`8928cce`](https://github.com/apache/spark/commit/8928cced28fc7116b7cabcf559277264c4c17318).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809820630
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809801061
**[Test build #136674 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136674/testReport)** for PR 31932 at commit [`3c0e507`](https://github.com/apache/spark/commit/3c0e5077722d39b25680870ba9d435aafc62466c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809625785
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809820620
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #31932: [SPARK-34906] Refactor TreeNode's children handling methods into specialized traits
Posted by GitBox <gi...@apache.org>.
hvanhovell closed pull request #31932:
URL: https://github.com/apache/spark/pull/31932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805122427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136409/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #31932: [SPARK-34906] Refactor TreeNode's children handling methods into specialized traits
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-810491866
Merging to master. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809820630
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805161973
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbaliafroozeh commented on pull request #31932: [SPARK-34906] Refactor TreeNode's children handling methods into specialized traits
Posted by GitBox <gi...@apache.org>.
dbaliafroozeh commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-811884973
@MaxGekk @cloud-fan I'll do your suggestions in a follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809384674
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136655/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805122427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136409/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809394550
**[Test build #136660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136660/testReport)** for PR 31932 at commit [`6e3f54a`](https://github.com/apache/spark/commit/6e3f54a4073b400ba1b0ed082c0f5c8b7e0a6dab).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809681900
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41242/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-805161973
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809801061
**[Test build #136674 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136674/testReport)** for PR 31932 at commit [`3c0e507`](https://github.com/apache/spark/commit/3c0e5077722d39b25680870ba9d435aafc62466c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804483530
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809901028
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136674/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809901028
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136674/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31932: [SPARK-34906] Refactor TreeNode's children handling methods into specialized traits
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31932:
URL: https://github.com/apache/spark/pull/31932#discussion_r604385968
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -428,10 +430,12 @@ case class InsertAction(
override def children: Seq[Expression] = condition.toSeq ++ assignments
}
-case class Assignment(key: Expression, value: Expression) extends Expression with Unevaluable {
+case class Assignment(key: Expression, value: Expression) extends Expression
+ with Unevaluable with BinaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
##########
@@ -33,12 +34,11 @@ import org.apache.spark.sql.types._
* We have to store all the collected elements in memory, and so notice that too many elements
* can cause GC paused and eventually OutOfMemory Errors.
*/
-abstract class Collect[T <: Growable[Any] with Iterable[Any]] extends TypedImperativeAggregate[T] {
+abstract class Collect[T <: Growable[Any] with Iterable[Any]] extends TypedImperativeAggregate[T]
+ with UnaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/bitwiseAggregates.scala
##########
@@ -18,16 +18,16 @@
package org.apache.spark.sql.catalyst.expressions.aggregate
import org.apache.spark.sql.catalyst.expressions.{AttributeReference, BinaryArithmetic, BitwiseAnd, BitwiseOr, BitwiseXor, ExpectsInputTypes, Expression, ExpressionDescription, If, IsNull, Literal}
+import org.apache.spark.sql.catalyst.trees.UnaryLike
import org.apache.spark.sql.types.{AbstractDataType, DataType, IntegralType}
-abstract class BitAggregate extends DeclarativeAggregate with ExpectsInputTypes {
+abstract class BitAggregate extends DeclarativeAggregate with ExpectsInputTypes
+ with UnaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PartitionTransforms.scala
##########
@@ -32,7 +33,8 @@ import org.apache.spark.sql.types.{DataType, IntegerType}
* df.writeTo("catalog.db.table").partitionedBy($"category", days($"timestamp")).create()
* }}}
*/
-abstract class PartitionTransformExpression extends Expression with Unevaluable {
+abstract class PartitionTransformExpression extends Expression with Unevaluable
+ with UnaryLike[Expression] {
Review comment:
nit: 2 spaces indentation, see https://github.com/databricks/scala-style-guide#spacing-and-indentation
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala
##########
@@ -34,10 +35,12 @@ import org.apache.spark.sql.types.{AbstractDataType, BooleanType, DataType, Long
""",
group = "agg_funcs",
since = "3.0.0")
-case class CountIf(predicate: Expression) extends UnevaluableAggregate with ImplicitCastInputTypes {
+case class CountIf(predicate: Expression) extends UnevaluableAggregate with ImplicitCastInputTypes
+ with UnaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
##########
@@ -37,9 +38,8 @@ import org.apache.spark.sql.types._
""",
group = "agg_funcs",
since = "1.0.0")
-case class Sum(child: Expression) extends DeclarativeAggregate with ImplicitCastInputTypes {
-
- override def children: Seq[Expression] = child :: Nil
+case class Sum(child: Expression) extends DeclarativeAggregate with ImplicitCastInputTypes
+ with UnaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -734,10 +741,12 @@ case class NthValue(input: Expression, offset: Expression, ignoreNulls: Boolean)
since = "2.0.0",
group = "window_funcs")
// scalastyle:on line.size.limit line.contains.tab
-case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindowFunction {
+case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindowFunction
+ with UnaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
##########
@@ -34,12 +35,11 @@ import org.apache.spark.sql.types._
""",
group = "agg_funcs",
since = "1.0.0")
-case class Average(child: Expression) extends DeclarativeAggregate with ImplicitCastInputTypes {
+case class Average(child: Expression) extends DeclarativeAggregate with ImplicitCastInputTypes
+ with UnaryLike[Expression] {
Review comment:
2 space indent
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -101,11 +102,11 @@ case class Rollup(groupByExprs: Seq[Expression]) extends GroupingSet {}
since = "2.0.0",
group = "agg_funcs")
// scalastyle:on line.size.limit line.contains.tab
-case class Grouping(child: Expression) extends Expression with Unevaluable {
+case class Grouping(child: Expression) extends Expression with Unevaluable
+ with UnaryLike[Expression] {
Review comment:
2 space indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804937090
**[Test build #136409 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136409/testReport)** for PR 31932 at commit [`b27bb4d`](https://github.com/apache/spark/commit/b27bb4dbd9a3b846f1365e7eb85216d7ef1d4202).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804937090
**[Test build #136409 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136409/testReport)** for PR 31932 at commit [`b27bb4d`](https://github.com/apache/spark/commit/b27bb4dbd9a3b846f1365e7eb85216d7ef1d4202).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804483530
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809624248
**[Test build #136660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136660/testReport)** for PR 31932 at commit [`6e3f54a`](https://github.com/apache/spark/commit/6e3f54a4073b400ba1b0ed082c0f5c8b7e0a6dab).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `sealed trait SpecialFrameBoundary extends LeafExpression with Unevaluable `
* `case class RowNumber() extends RowNumberLike with LeafLike[Expression] `
* `case class CumeDist() extends RowNumberLike with SizeBasedWindowFunction with LeafLike[Expression] `
* `case class Assignment(key: Expression, value: Expression) extends Expression`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809625785
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804427663
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809712671
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41242/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-809897848
**[Test build #136674 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136674/testReport)** for PR 31932 at commit [`3c0e507`](https://github.com/apache/spark/commit/3c0e5077722d39b25680870ba9d435aafc62466c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class UnaryExpression extends Expression with UnaryLike[Expression] `
* `abstract class BinaryExpression extends Expression with BinaryLike[Expression] `
* `abstract class TernaryExpression extends Expression with TernaryLike[Expression] `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31932: [WIP] Introduce specialized traits for TreeNode children handling
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31932:
URL: https://github.com/apache/spark/pull/31932#issuecomment-804474017
**[Test build #136360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136360/testReport)** for PR 31932 at commit [`8928cce`](https://github.com/apache/spark/commit/8928cced28fc7116b7cabcf559277264c4c17318).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Grouping(child: Expression) extends Expression with Unevaluable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org