You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/08 07:55:01 UTC
Re: Review Request 41858: Added helper functions to kill executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 2:55 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Summary (updated)
-----------------
Added helper functions to kill executor.
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
kill executors helper
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41858/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41858: Added helper functions to kill executor.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 8, 2016, 3:49 p.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 4886
> > <https://reviews.apache.org/r/41858/diff/2/?file=1187210#file1187210line4886>
> >
> > Should this be used also by qos_correction?
>
> Guangya Liu wrote:
> Want to leverage but because of `log` issues, the `qosCorrections` has many special logs related with QoS controller, it is difficult to make `qosCorrections` leverage this. Do you have any idea/comments for how to improve?
>
> Joseph Wu wrote:
> I would recommend refactoring out the body of `if (correction.type() == QoSCorrection::KILL) {`.
>
> Instead of logging directly, return an `Option<Error>`.
> The QoS controller can do `LOG(WARNING) << "Ignoring QoS correction KILL: " << error.get();`.
@Joseph, good suggestion. I'll move the common part into a function.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
-----------------------------------------------------------
On Jan. 8, 2016, 3:02 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41858/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 3:02 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> kill executors helper
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41858/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41858: Added helper functions to kill executor.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Jan. 7, 2016, 11:49 p.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 4886
> > <https://reviews.apache.org/r/41858/diff/2/?file=1187210#file1187210line4886>
> >
> > Should this be used also by qos_correction?
>
> Guangya Liu wrote:
> Want to leverage but because of `log` issues, the `qosCorrections` has many special logs related with QoS controller, it is difficult to make `qosCorrections` leverage this. Do you have any idea/comments for how to improve?
I would recommend refactoring out the body of `if (correction.type() == QoSCorrection::KILL) {`.
Instead of logging directly, return an `Option<Error>`.
The QoS controller can do `LOG(WARNING) << "Ignoring QoS correction KILL: " << error.get();`.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
-----------------------------------------------------------
On Jan. 7, 2016, 11:02 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41858/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:02 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> kill executors helper
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41858/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41858: Added helper functions to kill executor.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 8, 2016, 7:49 a.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 4886
> > <https://reviews.apache.org/r/41858/diff/2/?file=1187210#file1187210line4886>
> >
> > Should this be used also by qos_correction?
Want to leverage but because of `log` issues, the `qosCorrections` has many special logs related with QoS controller, it is difficult to make `qosCorrections` leverage this. Do you have any idea/comments for how to improve?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
-----------------------------------------------------------
On 一月 8, 2016, 7:02 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41858/
> -----------------------------------------------------------
>
> (Updated 一月 8, 2016, 7:02 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> kill executors helper
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41858/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41858: Added helper functions to kill executor.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
-----------------------------------------------------------
src/slave/slave.cpp (line 4886)
<https://reviews.apache.org/r/41858/#comment174062>
Should this be used also by qos_correction?
- Jian Qiu
On 一月 8, 2016, 7:02 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41858/
> -----------------------------------------------------------
>
> (Updated 一月 8, 2016, 7:02 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> kill executors helper
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41858/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41858: Added helper functions to kill executor.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/
-----------------------------------------------------------
(Updated March 11, 2016, 2:56 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
rebase
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
kill executors helper
Diffs (updated)
-----
src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
Diff: https://reviews.apache.org/r/41858/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41858: Added helper functions to kill executor.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 3:02 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
address comments
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
kill executors helper
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41858/diff/
Testing
-------
Thanks,
Klaus Ma