You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/05/16 04:32:55 UTC

[jira] Created: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Update FileBench to use the "work" directory for SequenceFileOutputFormat
-------------------------------------------------------------------------

                 Key: HADOOP-3401
                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
             Project: Hadoop Core
          Issue Type: Bug
          Components: test
            Reporter: Chris Douglas
             Fix For: 0.18.0


HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3401:
----------------------------------

    Status: Patch Available  (was: Open)

> Update FileBench to use the "work" directory for SequenceFileOutputFormat
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris Douglas
>             Fix For: 0.18.0
>
>         Attachments: 3401-0.patch
>
>
> HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas reassigned HADOOP-3401:
-------------------------------------

    Assignee: Chris Douglas

> Update FileBench to use the "work" directory for SequenceFileOutputFormat
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.18.0
>
>         Attachments: 3401-0.patch
>
>
> HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3401:
----------------------------------

    Attachment: 3401-0.patch

This patch sets the property manually. It's a hack, but it's in test code, so it's probably OK. Also added a unit test.

> Update FileBench to use the "work" directory for SequenceFileOutputFormat
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris Douglas
>             Fix For: 0.18.0
>
>         Attachments: 3401-0.patch
>
>
> HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3401:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Chris!

> Update FileBench to use the "work" directory for SequenceFileOutputFormat
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.18.0
>
>         Attachments: 3401-0.patch
>
>
> HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601468#action_12601468 ] 

Hudson commented on HADOOP-3401:
--------------------------------

Integrated in Hadoop-trunk #509 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/509/])

> Update FileBench to use the "work" directory for SequenceFileOutputFormat
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.18.0
>
>         Attachments: 3401-0.patch
>
>
> HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3401) Update FileBench to use the "work" directory for SequenceFileOutputFormat

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597344#action_12597344 ] 

Hadoop QA commented on HADOOP-3401:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12382151/3401-0.patch
  against trunk revision 656904.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/console

This message is automatically generated.

> Update FileBench to use the "work" directory for SequenceFileOutputFormat
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3401
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.18.0
>
>         Attachments: 3401-0.patch
>
>
> HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.