[GitHub] [apisix-ingress-controller] gxthrj commented on a diff in pull request #1016: e2e-test: add e2e tests and CRDs for ApisixClusterConfig v2

[GitBox <gi...@apache.org>]

gxthrj commented on code in PR #1016:
URL: https://github.com/apache/apisix-ingress-controller/pull/1016#discussion_r874709026


##########
test/e2e/scaffold/cluster_config.go:
##########
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package scaffold
+
+import (
+	"fmt"
+	"time"
+
+	"github.com/gruntwork-io/terratest/modules/k8s"
+)
+
+var (
+	_apisixClusterConfigTemplate = `
+apiVersion: %s
+kind: ApisixClusterConfig
+metadata:
+  name: %s
+spec:
+  monitoring:
+    prometheus:
+      enable: %v
+`
+)
+
+// NewApisixClusterConfig creates an ApisixClusterConfig CRD
+func (s *Scaffold) NewApisixClusterConfig(name string, enable bool) error {
+	cc := fmt.Sprintf(_apisixClusterConfigTemplate, s.opts.APISIXClusterConfigVersion, name, enable)
+	if err := k8s.KubectlApplyFromStringE(s.t, s.kubectlOptions, cc); err != nil {
+		return err
+	}
+	time.Sleep(5 * time.Second)
+	return nil
+}
+
+// DeleteApisixClusterConfig removes an ApisixClusterConfig CRD
+func (s *Scaffold) DeleteApisixClusterConfig(name string, enable bool) error {

Review Comment:
   The logic between `NewApisixClusterConfig` and `DeleteApisixClusterConfig` is actually the same.
   It is recommended to combine these two methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org