[GitHub] [spark] sunchao commented on pull request #34087: [SPARK-36821][SQL] Make class ColumnarBatch extendable - addendum

[GitBox <gi...@apache.org>]

sunchao commented on pull request #34087:
URL: https://github.com/apache/spark/pull/34087#issuecomment-926912982


   > We may still expose ColumnarBatchRow since any class extending the abstract class still needs it
   
   I'm thinking whether they can just use `ColumnarRow` instead.
   
   > One question for your code snippet, we should add the public method rowIterator, right? It is the major interface of the ColumnarBatch.
   
   Yea. We can have the class implement `Iterable<InternalRow>` which is a more standard Java API. We'll need to replace all the places that use `rowInterator` with `iterator` though. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org