You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/26 12:39:30 UTC

[GitHub] [flink] AlexRiedler opened a new pull request, #21167: [hotfix] [flink-parquet] avro parquet logical type fix

AlexRiedler opened a new pull request, #21167:
URL: https://github.com/apache/flink/pull/21167

   ## What is the purpose of the change
   
   Currently the code doesn't use the specified Avro Model's SpecificData record which means any logicalTypes registered on the avro type are unavailable resulting in an error. This is hot fix since this is an experimental module, and only fixes the current state of things for those that need it.
   
   ## Brief change log
   
    - Remove redundant schema serialization and de-serialization over and over
    - Make it so it uses the specific model as indicated instead of the generic 'SpecificData' model
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   This change is already covered by existing tests, such as the modified two tests (adding a logical type)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): NO
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: NO
     - The serializers: YES - writer factory. although experimental
     - The runtime per-record code paths (performance sensitive): NO
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: NO
     - The S3 file system connector: NO
   
   ## Documentation
   
     - Does this pull request introduce a new feature? NO
     - If yes, how is the feature documented? NOT APPLICABLE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] [flink-parquet] avro parquet logical type fix [flink]

Posted by "AlexRiedler (via GitHub)" <gi...@apache.org>.
AlexRiedler closed pull request #21167: [hotfix] [flink-parquet] avro parquet logical type fix
URL: https://github.com/apache/flink/pull/21167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AlexRiedler commented on pull request #21167: [hotfix] [flink-parquet] avro parquet logical type fix

Posted by GitBox <gi...@apache.org>.
AlexRiedler commented on PR #21167:
URL: https://github.com/apache/flink/pull/21167#issuecomment-1293040601

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21167: [hotfix] [flink-parquet] avro parquet logical type fix

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21167:
URL: https://github.com/apache/flink/pull/21167#issuecomment-1291981035

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "38f3d6d7dc43b23a758591565e1f45d63756ec52",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38f3d6d7dc43b23a758591565e1f45d63756ec52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 38f3d6d7dc43b23a758591565e1f45d63756ec52 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21167: [hotfix] [flink-parquet] avro parquet logical type fix

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21167:
URL: https://github.com/apache/flink/pull/21167#issuecomment-1293497386

   @AlexRiedler Thanks for the PR, but this shouldn't be a hotfix but requires a proper Jira


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org