You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/05/12 06:46:30 UTC
[PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Mryange opened a new pull request, #63164:
URL: https://github.com/apache/doris/pull/63164
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
`check_and_get_column` returns nullptr when the column type doesn't match, but many call sites either:
- used the result without null-checking, risking silent null dereference, or
- wrapped it in an `if (ptr)` / `else { throw FatalError }` pattern, which is exactly what `assert_cast` does — but with a clearer error message.
Root cause: these call sites always expect a specific column type. The type invariant is guaranteed by upstream logic, so a null-return path is dead code that obscures the real contract.
Fix: replace `check_and_get_column<T>(column)` with `assert_cast<const T*>(&column)`, which asserts the type match immediately. Also removed the dead else-throw branches that became unreachable.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4431022783
<details>
<summary>TPC-DS: <b>Total hot run time: 170354 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be9ea3bab91a94f779966d2c0c04c3f62617fbdf, data reload: false
query5 4332 660 507 507
query6 347 225 207 207
query7 4233 558 320 320
query8 317 230 220 220
query9 8798 3962 3940 3940
query10 444 350 288 288
query11 5765 2374 2171 2171
query12 183 131 128 128
query13 1284 627 425 425
query14 6638 5352 5027 5027
query14_1 4331 4314 4331 4314
query15 211 204 179 179
query16 1020 483 427 427
query17 1128 759 621 621
query18 2773 485 347 347
query19 215 205 158 158
query20 140 133 129 129
query21 212 136 112 112
query22 13548 13809 14472 13809
query23 17353 16561 16214 16214
query23_1 16333 16403 16379 16379
query24 7875 1827 1362 1362
query24_1 1351 1341 1366 1341
query25 588 510 455 455
query26 1321 317 176 176
query27 2672 572 339 339
query28 4358 1936 1946 1936
query29 1050 667 543 543
query30 306 234 192 192
query31 1133 1084 942 942
query32 87 74 73 73
query33 555 360 323 323
query34 1171 1184 638 638
query35 767 788 684 684
query36 1326 1350 1213 1213
query37 154 103 88 88
query38 3170 3113 3082 3082
query39 933 913 880 880
query39_1 868 881 863 863
query40 231 156 136 136
query41 73 66 66 66
query42 111 109 111 109
query43 323 323 288 288
query44
query45 214 204 187 187
query46 1060 1184 678 678
query47 2317 2356 2164 2164
query48 403 402 300 300
query49 632 516 419 419
query50 688 282 209 209
query51 4298 4273 4211 4211
query52 100 107 92 92
query53 247 285 196 196
query54 307 267 254 254
query55 90 89 83 83
query56 290 298 319 298
query57 1409 1396 1299 1299
query58 293 265 265 265
query59 1502 1581 1373 1373
query60 341 327 321 321
query61 154 155 155 155
query62 669 618 565 565
query63 249 203 249 203
query64 2353 817 674 674
query65
query66 1687 516 393 393
query67 30110 29407 29813 29407
query68
query69 454 340 301 301
query70 1016 963 997 963
query71 304 276 274 274
query72 2936 2717 2427 2427
query73 824 717 451 451
query74 5056 4866 4718 4718
query75 2776 2669 2327 2327
query76 2290 1125 742 742
query77 401 414 366 366
query78 12964 13018 12396 12396
query79 1432 1015 723 723
query80 970 579 484 484
query81 516 279 244 244
query82 1350 157 121 121
query83 356 273 255 255
query84 265 144 111 111
query85 894 515 441 441
query86 427 331 327 327
query87 3398 3351 3192 3192
query88 3508 2665 2630 2630
query89 441 385 335 335
query90 1828 176 182 176
query91 175 167 143 143
query92 79 78 69 69
query93 954 986 562 562
query94 635 353 297 297
query95 643 465 350 350
query96 1003 776 335 335
query97 2716 2692 2549 2549
query98 236 228 228 228
query99 1091 1163 997 997
Total cold run time: 254349 ms
Total hot run time: 170354 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4447054619
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4430935099
<details>
<summary>TPC-H: <b>Total hot run time: 29535 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be9ea3bab91a94f779966d2c0c04c3f62617fbdf, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17631 3873 3852 3852
q2 q3 10689 894 616 616
q4 4665 471 358 358
q5 7469 1322 1131 1131
q6 187 171 138 138
q7 941 959 744 744
q8 9636 1476 1289 1289
q9 6360 5399 5423 5399
q10 6364 2087 1810 1810
q11 476 260 249 249
q12 689 422 300 300
q13 18177 3331 2772 2772
q14 288 280 261 261
q15 q16 901 872 802 802
q17 1024 1049 669 669
q18 6457 5784 5571 5571
q19 1180 1213 1119 1119
q20 530 381 271 271
q21 4599 2277 1880 1880
q22 412 353 304 304
Total cold run time: 98675 ms
Total hot run time: 29535 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4167 4083 4092 4083
q2 q3 4644 4771 4170 4170
q4 2100 2173 1380 1380
q5 4961 4995 5270 4995
q6 194 164 130 130
q7 2020 1969 1730 1730
q8 3442 3282 3214 3214
q9 8822 8389 8356 8356
q10 4486 4521 4277 4277
q11 638 443 419 419
q12 703 800 545 545
q13 3182 3616 2899 2899
q14 302 315 281 281
q15 q16 765 795 736 736
q17 1373 1330 1421 1330
q18 8077 7090 7128 7090
q19 1179 1185 1182 1182
q20 2248 2257 1930 1930
q21 6065 5409 4886 4886
q22 572 522 417 417
Total cold run time: 59940 ms
Total hot run time: 54050 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4429485693
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4435932316
# BE UT Coverage Report
Increment line coverage `30.94% (43/139)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/1b3ccbaeb719f876132ee9d3aceec172005b5278_1b3ccbaeb719f876132ee9d3aceec172005b5278/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/1b3ccbaeb719f876132ee9d3aceec172005b5278_1b3ccbaeb719f876132ee9d3aceec172005b5278/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.57% (20634/38518) |
| Line Coverage | 37.20% (194960/524077) |
| Region Coverage | 33.60% (152413/453649) |
| Branch Coverage | 34.59% (66452/192097) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4429942911
<details>
<summary>TPC-DS: <b>Total hot run time: 171581 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be9ea3bab91a94f779966d2c0c04c3f62617fbdf, data reload: false
query5 4326 660 515 515
query6 337 217 196 196
query7 4334 570 290 290
query8 323 232 216 216
query9 8808 3964 3956 3956
query10 468 345 290 290
query11 5820 2408 2209 2209
query12 191 133 129 129
query13 1287 603 445 445
query14 6838 5371 5074 5074
query14_1 4402 4353 4359 4353
query15 211 204 190 190
query16 1043 462 455 455
query17 1359 790 638 638
query18 2738 485 370 370
query19 296 214 178 178
query20 139 138 139 138
query21 233 146 116 116
query22 13687 13601 13399 13399
query23 17159 16404 16680 16404
query23_1 16382 16440 16289 16289
query24 7520 1833 1414 1414
query24_1 1404 1343 1334 1334
query25 566 479 424 424
query26 1305 314 166 166
query27 2674 581 341 341
query28 4394 1923 1912 1912
query29 967 610 519 519
query30 296 246 204 204
query31 1106 1068 924 924
query32 80 75 71 71
query33 528 342 286 286
query34 1139 1122 656 656
query35 754 784 661 661
query36 1388 1310 1212 1212
query37 150 95 88 88
query38 3182 3097 3074 3074
query39 934 911 875 875
query39_1 873 871 867 867
query40 237 163 136 136
query41 62 60 59 59
query42 109 106 107 106
query43 320 321 284 284
query44
query45 212 204 190 190
query46 1064 1178 735 735
query47 2348 2339 2214 2214
query48 390 402 291 291
query49 626 529 420 420
query50 718 279 210 210
query51 4281 4334 4260 4260
query52 105 106 94 94
query53 259 271 203 203
query54 311 270 248 248
query55 89 87 84 84
query56 306 302 306 302
query57 1408 1405 1335 1335
query58 296 275 273 273
query59 1552 1636 1424 1424
query60 344 344 323 323
query61 161 158 162 158
query62 671 623 562 562
query63 246 207 203 203
query64 2316 828 658 658
query65
query66 1672 516 391 391
query67 29370 30030 29802 29802
query68
query69 459 332 309 309
query70 991 1000 977 977
query71 311 279 279 279
query72 2908 2690 2473 2473
query73 837 757 459 459
query74 5052 4928 4742 4742
query75 2792 2689 2345 2345
query76 2319 1142 776 776
query77 424 436 352 352
query78 13100 13006 12335 12335
query79 1475 950 717 717
query80 1092 580 481 481
query81 504 278 237 237
query82 1324 158 121 121
query83 361 271 246 246
query84 256 143 109 109
query85 935 539 447 447
query86 434 339 340 339
query87 3387 3374 3217 3217
query88 3517 2671 2671 2671
query89 440 384 342 342
query90 1816 175 183 175
query91 180 180 137 137
query92 82 76 74 74
query93 969 943 560 560
query94 622 342 306 306
query95 662 365 367 365
query96 1038 772 312 312
query97 2695 2700 2594 2594
query98 257 232 235 232
query99 1086 1090 971 971
Total cold run time: 254340 ms
Total hot run time: 171581 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4427998081
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4431213734
<details>
<summary>TPC-DS: <b>Total hot run time: 171523 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b3ccbaeb719f876132ee9d3aceec172005b5278, data reload: false
query5 4325 673 525 525
query6 323 215 200 200
query7 4286 568 297 297
query8 329 239 219 219
query9 8814 3977 3972 3972
query10 444 336 301 301
query11 5775 2383 2182 2182
query12 186 132 131 131
query13 1306 584 442 442
query14 6029 5374 5082 5082
query14_1 4439 4425 4385 4385
query15 221 207 187 187
query16 1005 456 451 451
query17 939 774 659 659
query18 2496 506 379 379
query19 222 208 182 182
query20 151 136 134 134
query21 219 144 119 119
query22 13592 13954 14526 13954
query23 17431 16543 16285 16285
query23_1 16265 16271 16164 16164
query24 7453 1754 1332 1332
query24_1 1357 1446 1356 1356
query25 573 493 446 446
query26 1294 302 167 167
query27 2745 582 335 335
query28 4423 1930 1953 1930
query29 983 633 533 533
query30 301 228 200 200
query31 1095 1065 921 921
query32 83 72 67 67
query33 529 344 293 293
query34 1146 1128 628 628
query35 774 784 667 667
query36 1316 1309 1096 1096
query37 161 99 89 89
query38 3181 3159 3031 3031
query39 940 902 907 902
query39_1 886 865 874 865
query40 233 154 137 137
query41 63 61 60 60
query42 108 106 106 106
query43 320 339 287 287
query44
query45 210 200 195 195
query46 1079 1184 723 723
query47 2314 2287 2210 2210
query48 397 381 294 294
query49 632 523 431 431
query50 692 295 212 212
query51 4254 4316 4217 4217
query52 105 104 93 93
query53 255 274 200 200
query54 312 280 266 266
query55 95 90 88 88
query56 312 307 300 300
query57 1398 1356 1318 1318
query58 298 269 267 267
query59 1543 1616 1388 1388
query60 344 337 355 337
query61 161 157 153 153
query62 689 616 564 564
query63 247 206 214 206
query64 2429 823 678 678
query65
query66 1725 521 399 399
query67 29942 29895 29904 29895
query68
query69 473 341 304 304
query70 1011 989 973 973
query71 319 283 277 277
query72 2948 2711 2392 2392
query73 851 737 424 424
query74 5060 4913 4746 4746
query75 2806 2650 2314 2314
query76 2268 1136 774 774
query77 411 422 345 345
query78 12905 12969 12105 12105
query79 1488 954 702 702
query80 1347 583 507 507
query81 503 282 240 240
query82 1312 162 120 120
query83 355 271 252 252
query84 307 136 110 110
query85 960 551 459 459
query86 451 323 332 323
query87 3396 3333 3209 3209
query88 3499 2648 2632 2632
query89 434 378 336 336
query90 1933 185 180 180
query91 184 181 136 136
query92 77 78 72 72
query93 963 989 568 568
query94 728 339 295 295
query95 689 464 350 350
query96 991 778 357 357
query97 2696 2660 2537 2537
query98 242 237 228 228
query99 1101 1095 919 919
Total cold run time: 253914 ms
Total hot run time: 171523 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4428194513
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4429858658
<details>
<summary>TPC-H: <b>Total hot run time: 29635 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be9ea3bab91a94f779966d2c0c04c3f62617fbdf, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17713 3842 3823 3823
q2 q3 10707 865 612 612
q4 4677 456 347 347
q5 7437 1326 1134 1134
q6 188 168 137 137
q7 899 935 760 760
q8 9305 1429 1295 1295
q9 5586 5388 5335 5335
q10 6256 2060 1825 1825
q11 465 267 258 258
q12 627 421 291 291
q13 18111 3328 2745 2745
q14 286 285 267 267
q15 q16 896 870 791 791
q17 1015 1046 795 795
q18 6488 5698 5620 5620
q19 1184 1273 1042 1042
q20 510 405 257 257
q21 4711 2402 1970 1970
q22 495 421 331 331
Total cold run time: 97556 ms
Total hot run time: 29635 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4784 4738 4850 4738
q2 q3 4672 4775 4198 4198
q4 2123 2175 1443 1443
q5 4990 5076 5276 5076
q6 197 177 146 146
q7 2075 1783 1624 1624
q8 3357 3095 3146 3095
q9 8422 8374 8361 8361
q10 4489 4487 4228 4228
q11 618 416 386 386
q12 706 771 509 509
q13 3166 3581 2841 2841
q14 307 318 276 276
q15 q16 748 772 778 772
q17 1328 1307 1231 1231
q18 7922 7123 7163 7123
q19 1202 1135 1144 1135
q20 2244 2237 1960 1960
q21 6120 5385 4874 4874
q22 546 511 426 426
Total cold run time: 60016 ms
Total hot run time: 54442 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4431105197
<details>
<summary>TPC-H: <b>Total hot run time: 29431 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b3ccbaeb719f876132ee9d3aceec172005b5278, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17600 3892 3853 3853
q2 q3 10726 897 620 620
q4 4658 455 352 352
q5 7446 1322 1143 1143
q6 184 169 137 137
q7 903 929 739 739
q8 9302 1414 1251 1251
q9 5597 5357 5319 5319
q10 6270 2098 1821 1821
q11 477 274 256 256
q12 631 409 299 299
q13 18085 3366 2710 2710
q14 295 285 259 259
q15 q16 904 878 785 785
q17 909 946 798 798
q18 6410 5704 5647 5647
q19 1187 1216 1010 1010
q20 491 387 259 259
q21 4474 2280 1874 1874
q22 411 356 299 299
Total cold run time: 96960 ms
Total hot run time: 29431 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4145 4067 4089 4067
q2 q3 4607 4768 4203 4203
q4 2087 2167 1371 1371
q5 4957 4937 5215 4937
q6 186 166 130 130
q7 2015 1776 1590 1590
q8 3795 3274 3287 3274
q9 8610 8579 8576 8576
q10 4477 4504 4265 4265
q11 607 435 403 403
q12 689 750 533 533
q13 3445 3573 2953 2953
q14 296 309 293 293
q15 q16 795 801 728 728
q17 1336 1277 1269 1269
q18 8207 7252 7091 7091
q19 1164 1211 1168 1168
q20 2240 2223 1938 1938
q21 6132 5390 4855 4855
q22 573 509 442 442
Total cold run time: 60363 ms
Total hot run time: 54086 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4427997607
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4428373013
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4446736126
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange merged PR #63164:
URL: https://github.com/apache/doris/pull/63164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4435608808
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4430944335
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4435959094
# BE Regression && UT Coverage Report
Increment line coverage `89.21% (124/139)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63164_1b3ccbaeb719f876132ee9d3aceec172005b5278_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63164_1b3ccbaeb719f876132ee9d3aceec172005b5278_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.68% (27793/37719) |
| Line Coverage | 57.51% (300614/522699) |
| Region Coverage | 54.72% (250647/458066) |
| Branch Coverage | 56.23% (108431/192825) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4428389085
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4429706151
<details>
<summary>TPC-H: <b>Total hot run time: 29495 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aedf140c959d53911dc372ee7812050579830822, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17696 3856 3917 3856
q2 q3 10714 884 621 621
q4 4659 470 347 347
q5 7551 1320 1128 1128
q6 255 179 146 146
q7 942 933 758 758
q8 10361 1396 1331 1331
q9 6782 5395 5326 5326
q10 6323 2086 1813 1813
q11 470 275 260 260
q12 697 425 302 302
q13 18160 3336 2768 2768
q14 295 287 259 259
q15 q16 903 879 786 786
q17 1013 983 722 722
q18 6544 5726 5541 5541
q19 1286 1277 1050 1050
q20 529 389 266 266
q21 4773 2303 1909 1909
q22 430 351 306 306
Total cold run time: 100383 ms
Total hot run time: 29495 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4240 4175 4084 4084
q2 q3 4614 4805 4158 4158
q4 2097 2156 1382 1382
q5 4966 4976 5249 4976
q6 200 174 137 137
q7 2301 1858 1624 1624
q8 3520 3195 3155 3155
q9 8565 8451 8428 8428
q10 4572 4550 4247 4247
q11 632 423 401 401
q12 702 748 529 529
q13 3258 3582 2896 2896
q14 295 301 278 278
q15 q16 774 799 695 695
q17 1322 1326 1447 1326
q18 8145 7078 7013 7013
q19 1156 1205 1168 1168
q20 2259 2248 1963 1963
q21 6111 5416 4930 4930
q22 550 545 446 446
Total cold run time: 60279 ms
Total hot run time: 53836 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) replace misused check_and_get_column with assert_cast [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63164:
URL: https://github.com/apache/doris/pull/63164#issuecomment-4447054425
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org