You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/04 05:44:23 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
HyukjinKwon opened a new pull request #32780:
URL: https://github.com/apache/spark/pull/32780
### What changes were proposed in this pull request?
This PR proposes to update `dev/requirement.txt` file.
NOTE that:
- This file isn't used anymore in Apache Spark CI. It's just for convenience
- To minimize the overhead of maintenance, I removed all lowerbounds of dependencies, which means that using the latest versions of them should work in the clean environment (e.g., you can reinstall all of them).
### Why are the changes needed?
To note the dependencies needed for Spark dev, and for easier env setting up.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Logically derived from setup.py, and other places like CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32780:
URL: https://github.com/apache/spark/pull/32780#issuecomment-854377927
I added some more comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32780:
URL: https://github.com/apache/spark/pull/32780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32780:
URL: https://github.com/apache/spark/pull/32780#discussion_r645307193
##########
File path: dev/requirements.txt
##########
@@ -1,8 +1,34 @@
-flake8==3.5.0
-jira==2.0.0
-PyGithub==1.26.0
-sphinx
+# PySpark dependencies (required)
+py4j
+
+# PySpark dependencies (optional)
+numpy
+pyarrow
+pandas
+scipy
+plotly
+mlflow
+matplotlib<3.3.0
+
+# PySpark test dependencies
+xmlrunner
+
+# Linter
+mypy
+flake8
+
+# Documentation (SQL)
+mkdocs
+
+# Documentation (Python)
pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+jinja2<3.0.0
+sphinx<3.1.0
+sphinx-plotly-directive
+
+# Developement scripts
Review comment:
nit. Typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32780:
URL: https://github.com/apache/spark/pull/32780#issuecomment-854384361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32780:
URL: https://github.com/apache/spark/pull/32780#issuecomment-854375864
cc @srowen @dongjoon-hyun FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32780:
URL: https://github.com/apache/spark/pull/32780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32780:
URL: https://github.com/apache/spark/pull/32780#discussion_r645307193
##########
File path: dev/requirements.txt
##########
@@ -1,8 +1,34 @@
-flake8==3.5.0
-jira==2.0.0
-PyGithub==1.26.0
-sphinx
+# PySpark dependencies (required)
+py4j
+
+# PySpark dependencies (optional)
+numpy
+pyarrow
+pandas
+scipy
+plotly
+mlflow
+matplotlib<3.3.0
+
+# PySpark test dependencies
+xmlrunner
+
+# Linter
+mypy
+flake8
+
+# Documentation (SQL)
+mkdocs
+
+# Documentation (Python)
pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+jinja2<3.0.0
+sphinx<3.1.0
+sphinx-plotly-directive
+
+# Developement scripts
Review comment:
nit. Typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32780:
URL: https://github.com/apache/spark/pull/32780#issuecomment-854375864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32780:
URL: https://github.com/apache/spark/pull/32780#discussion_r645310283
##########
File path: dev/requirements.txt
##########
@@ -1,8 +1,34 @@
-flake8==3.5.0
-jira==2.0.0
-PyGithub==1.26.0
-sphinx
+# PySpark dependencies (required)
+py4j
+
+# PySpark dependencies (optional)
+numpy
+pyarrow
+pandas
+scipy
+plotly
+mlflow
+matplotlib<3.3.0
+
+# PySpark test dependencies
+xmlrunner
+
+# Linter
+mypy
+flake8
+
+# Documentation (SQL)
+mkdocs
+
+# Documentation (Python)
pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+jinja2<3.0.0
+sphinx<3.1.0
+sphinx-plotly-directive
+
+# Developement scripts
Review comment:
```suggestion
# Development scripts
```
##########
File path: dev/requirements.txt
##########
@@ -1,8 +1,34 @@
-flake8==3.5.0
-jira==2.0.0
-PyGithub==1.26.0
-sphinx
+# PySpark dependencies (required)
+py4j
+
+# PySpark dependencies (optional)
+numpy
+pyarrow
+pandas
+scipy
+plotly
+mlflow
+matplotlib<3.3.0
+
+# PySpark test dependencies
+xmlrunner
+
+# Linter
+mypy
+flake8
+
+# Documentation (SQL)
+mkdocs
+
+# Documentation (Python)
pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+jinja2<3.0.0
+sphinx<3.1.0
+sphinx-plotly-directive
+
+# Developement scripts
Review comment:
oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32780: [SPARK-35648][PYTHON] Refine and add dependencies needed for dev in dev/requirement.txt
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32780:
URL: https://github.com/apache/spark/pull/32780#discussion_r645310283
##########
File path: dev/requirements.txt
##########
@@ -1,8 +1,34 @@
-flake8==3.5.0
-jira==2.0.0
-PyGithub==1.26.0
-sphinx
+# PySpark dependencies (required)
+py4j
+
+# PySpark dependencies (optional)
+numpy
+pyarrow
+pandas
+scipy
+plotly
+mlflow
+matplotlib<3.3.0
+
+# PySpark test dependencies
+xmlrunner
+
+# Linter
+mypy
+flake8
+
+# Documentation (SQL)
+mkdocs
+
+# Documentation (Python)
pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+jinja2<3.0.0
+sphinx<3.1.0
+sphinx-plotly-directive
+
+# Developement scripts
Review comment:
```suggestion
# Development scripts
```
##########
File path: dev/requirements.txt
##########
@@ -1,8 +1,34 @@
-flake8==3.5.0
-jira==2.0.0
-PyGithub==1.26.0
-sphinx
+# PySpark dependencies (required)
+py4j
+
+# PySpark dependencies (optional)
+numpy
+pyarrow
+pandas
+scipy
+plotly
+mlflow
+matplotlib<3.3.0
+
+# PySpark test dependencies
+xmlrunner
+
+# Linter
+mypy
+flake8
+
+# Documentation (SQL)
+mkdocs
+
+# Documentation (Python)
pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+jinja2<3.0.0
+sphinx<3.1.0
+sphinx-plotly-directive
+
+# Developement scripts
Review comment:
oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org