You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2023/06/08 00:40:48 UTC
[GitHub] [kafka] mumrah opened a new pull request, #13827: KAFKA-15073: Add a Github action to mark PRs as stale
mumrah opened a new pull request, #13827:
URL: https://github.com/apache/kafka/pull/13827
This patch uses a Github workflow to mark inactive PRs with the `stale` label. The workflow uses the ["stale" action](https://github.com/actions/stale) which has many features including a number of filtering options and the ability to auto-closing issues.
For this patch, I've disable auto-closing PRs and just have it add the label for PRs with more than 90 days of inactivity. I've also enabled the "dry-run" option while we discuss the configuration.
The workflow will run nightly at 3:30 UTC. It can also be triggered manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] danielgospodinow commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "danielgospodinow (via GitHub)" <gi...@apache.org>.
danielgospodinow commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1223881556
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
Review Comment:
Maybe we can add an additional comment here to explain that there's a plan to use this cron schedule for nightly running of the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225158578
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
+ stale-issue-label: 'stale'
+ stale-pr-message: 'This PR is stale because it has been open 90 days with no activity.'
Review Comment:
Should we expand the comment a little more? For instance, we could explain we the contributors could do (e.g. nag us, fix conflicts, close, etc)? We could also apologize for the delay…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225160146
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
Review Comment:
Why don’t we close them as well after another 30 days? It won’t be close of a reviewer or the contributor reacts. I am saying this because without closing them, it does not really help with reducing the backlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225356594
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
+ stale-issue-label: 'stale'
+ stale-pr-message: >
+ This PR is being marked as stale since it has not had any activity in 90 days. If you
+ would like to keep this PR alive, please update it with the latest from trunk and ask
Review Comment:
There are plenty of PRs that are stale but no further action from the author is needed. I would add a conditional in there.
"...please update it with the latest from trunk if there is a merge conflict and ask..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1223425372
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
Review Comment:
I think 90 days is a long time but looking at our queue, I think it's a realistic value to start with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13827:
URL: https://github.com/apache/kafka/pull/13827#issuecomment-1583155790
> I also found https://github.com/marketplace/actions/auto-label-merge-conflicts which would add a label to PRs with conflicts. This could be used to create two separate workflows of the "stale" action.
This is a good one, I think we can combine these 2 actions and make them run to accomplish what we need. Mark PRs with merge conflicts with a label, and then we can run the stale job twice, one excluding the conflict label and another one only for the conflict label.
> Do you agree that we can scope this PR to "marking old PRs as stale" for the sake of clearing our backlog?
Yes this makes sense. I'll work on the other one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225347286
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
Review Comment:
We can't actually test the functionality of the action in a PR, so I was going to commit it without the automatic schedule so we could manually run it as a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225159124
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
+ stale-issue-label: 'stale'
+ stale-pr-message: 'This PR is stale because it has been open 90 days with no activity.'
Review Comment:
For instance, i like this one: https://github.com/apache/spark/blob/master/.github/workflows/stale.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225354535
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
Review Comment:
I also think that having a dry run first and see that the right PRs would be flagged is a good approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1222732234
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
+ stale-issue-label: 'stale'
Review Comment:
I would probably add the message there:
`stale-pr-message: 'This PR is stale because it has been open 90 days with no activity.'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225352321
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
Review Comment:
I'd like to in a future PR. Since we can't test the action until it's committed, I wanted to hold off on doing anything "destructive" like closing a bunch of PRs :)
After testing this manually with the dry-run option, I'll raise a PR to add the schedule and close PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225160146
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+ inputs:
+ dryRun:
+ description: 'Dry Run'
+ required: true
+ default: true
+ type: boolean
+ operationsPerRun:
+ description: 'Max GitHub API operations'
+ required: true
+ default: 30
+ type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
Review Comment:
Why don’t we close them as well after another 30 days? It won’t be close of a reviewer or the contributor reacts. I am saying this because without closing them, it does not really with reducing the backlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #13827:
URL: https://github.com/apache/kafka/pull/13827#issuecomment-1582676925
Thanks for taking a look @jlprat!
For the more complex workflow, we could use https://github.com/actions/github-script. This basically lets you do anything that the Github API allows (kind of like using Groovy in a Gradle build 😄).
I also found https://github.com/marketplace/actions/auto-label-merge-conflicts which would add a label to PRs with conflicts. This could be used to create two separate workflows of the "stale" action.
I think there's a lot of flexibility with the actions available.
Do you agree that we can scope this PR to "marking old PRs as stale" for the sake of clearing our backlog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah merged pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #13827:
URL: https://github.com/apache/kafka/pull/13827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225159322
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
Review Comment:
Any reason why we don’t enable it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org