You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/09/22 23:02:41 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result
dongjoon-hyun opened a new pull request, #43065:
URL: https://github.com/apache/spark/pull/43065
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43065:
URL: https://github.com/apache/spark/pull/43065#issuecomment-1732193905
Thank you, @LuciferYang . Now, the PR is ready by adding AnsiIntervalSortBenchmark (Java17/21).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43065:
URL: https://github.com/apache/spark/pull/43065#issuecomment-1732121987
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43065:
URL: https://github.com/apache/spark/pull/43065#discussion_r1334909906
##########
sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt:
##########
@@ -1,10 +1,10 @@
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
constructor: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-arrayOfAny 4 4 0 2491.5 0.4 1.0X
-arrayOfAnyAsObject 256 257 1 39.1 25.6 0.0X
-arrayOfAnyAsSeq 18 18 0 551.9 1.8 0.2X
-arrayOfInt 536 537 1 18.7 53.6 0.0X
-arrayOfIntAsObject 788 794 10 12.7 78.8 0.0X
+arrayOfAny 7 7 0 1495.4 0.7 1.0X
+arrayOfAnyAsObject 7 7 0 1495.3 0.7 1.0X
+arrayOfAnyAsSeq 201 202 1 49.8 20.1 0.0X
Review Comment:
The results of `arrayOfAnyAsSeq` have undergone significant changes and need attention (it may be a known issue, but I can't remember the details).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43065:
URL: https://github.com/apache/spark/pull/43065#discussion_r1334911491
##########
core/benchmarks/ZStandardBenchmark-results.txt:
##########
@@ -2,26 +2,26 @@
Benchmark ZStandardCompressionCodec
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_372-b07 on Linux 5.15.0-1041-azure
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Benchmark ZStandardCompressionCodec: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------------------
-Compression 10000 times at level 1 without buffer pool 293 327 85 0.0 29283.2 1.0X
-Compression 10000 times at level 2 without buffer pool 322 324 2 0.0 32184.8 0.9X
-Compression 10000 times at level 3 without buffer pool 453 456 2 0.0 45285.1 0.6X
-Compression 10000 times at level 1 with buffer pool 171 173 1 0.1 17065.2 1.7X
-Compression 10000 times at level 2 with buffer pool 208 209 1 0.0 20786.5 1.4X
-Compression 10000 times at level 3 with buffer pool 334 335 2 0.0 33350.3 0.9X
+Compression 10000 times at level 1 without buffer pool 2800 2801 2 0.0 279995.2 1.0X
Review Comment:
Yes, this one has been on my todo list. Will try to identify the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43065:
URL: https://github.com/apache/spark/pull/43065#discussion_r1334916319
##########
sql/core/benchmarks/SortBenchmark-results.txt:
##########
@@ -2,15 +2,15 @@
radix sort
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
radix sort 25000000: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-reference TimSort key prefix array 12374 12403 41 2.0 495.0 1.0X
-reference Arrays.sort 3377 3381 5 7.4 135.1 3.7X
-radix sort one byte 209 212 2 119.5 8.4 59.2X
-radix sort two bytes 398 403 3 62.8 15.9 31.1X
-radix sort eight bytes 1538 1538 0 16.3 61.5 8.0X
-radix sort key prefix array 1953 1998 64 12.8 78.1 6.3X
+reference TimSort key prefix array 14141 14208 96 1.8 565.6 1.0X
Review Comment:
ditto
##########
sql/core/benchmarks/ColumnarBatchBenchmark-results.txt:
##########
@@ -2,58 +2,58 @@
Int Read/Write
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Int Read/Write: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-Java Array 257 266 8 1273.6 0.8 1.0X
-ByteBuffer Unsafe 480 490 5 682.0 1.5 0.5X
-ByteBuffer API 1994 1996 2 164.4 6.1 0.1X
-DirectByteBuffer 756 762 7 433.6 2.3 0.3X
-Unsafe Buffer 255 263 4 1283.1 0.8 1.0X
-Column(on heap) 266 272 6 1231.5 0.8 1.0X
-Column(off heap) 526 529 2 623.1 1.6 0.5X
-Column(off heap direct) 258 265 7 1270.3 0.8 1.0X
-UnsafeRow (on heap) 556 560 6 589.0 1.7 0.5X
-UnsafeRow (off heap) 599 606 5 546.9 1.8 0.4X
-Column On Heap Append 478 488 6 686.0 1.5 0.5X
+Java Array 254 261 5 1290.1 0.8 1.0X
+ByteBuffer Unsafe 420 427 8 780.2 1.3 0.6X
+ByteBuffer API 801 822 28 409.0 2.4 0.3X
+DirectByteBuffer 661 668 7 495.8 2.0 0.4X
+Unsafe Buffer 253 266 10 1296.0 0.8 1.0X
+Column(on heap) 254 261 4 1292.2 0.8 1.0X
+Column(off heap) 255 261 5 1287.3 0.8 1.0X
+Column(off heap direct) 253 258 6 1297.3 0.8 1.0X
+UnsafeRow (on heap) 722 729 9 454.1 2.2 0.4X
+UnsafeRow (off heap) 532 543 13 616.3 1.6 0.5X
+Column On Heap Append 516 522 7 635.2 1.6 0.5X
================================================================================================
Boolean Read/Write
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Boolean Read/Write: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-Bitset 1133 1135 3 296.1 3.4 1.0X
-Byte Array 773 775 3 434.3 2.3 1.5X
+Bitset 984 989 6 341.0 2.9 1.0X
+Byte Array 628 635 6 534.7 1.9 1.6X
================================================================================================
String Read/Write
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
String Read/Write: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-On Heap 430 442 9 38.1 26.3 1.0X
-Off Heap 756 771 14 21.7 46.1 0.6X
+On Heap 435 439 5 37.7 26.5 1.0X
+Off Heap 812 821 10 20.2 49.6 0.5X
================================================================================================
Array Vector Read
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Array Vector Read: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-On Heap Read Size Only 496 503 5 330.4 3.0 1.0X
-Off Heap Read Size Only 306 316 6 534.7 1.9 1.6X
-On Heap Read Elements 3301 3321 28 49.6 20.1 0.2X
-Off Heap Read Elements 5151 5179 41 31.8 31.4 0.1X
+On Heap Read Size Only 93 97 2 1752.8 0.6 1.0X
+Off Heap Read Size Only 107 114 4 1531.1 0.7 0.9X
Review Comment:
Perhaps it's also a case worth paying attention to. `Off Heap Read Size Only` has become slower than onheap.
##########
sql/core/benchmarks/SubExprEliminationBenchmark-results.txt:
##########
@@ -3,23 +3,23 @@ Benchmark for performance of subexpression elimination
================================================================================================
Preparing data for benchmarking ...
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
from_json as subExpr in Project: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-subExprElimination false, codegen: true 6737 6973 320 0.0 67369399.0 1.0X
-subExprElimination false, codegen: false 6271 6373 88 0.0 62710705.3 1.1X
-subExprElimination true, codegen: true 867 870 3 0.0 8666868.2 7.8X
-subExprElimination true, codegen: false 811 824 23 0.0 8107336.6 8.3X
+subExprElimination false, codegen: true 8437 8618 196 0.0 84373053.3 1.0X
+subExprElimination false, codegen: false 8291 8425 227 0.0 82910513.2 1.0X
+subExprElimination true, codegen: true 2180 2231 45 0.0 21795155.9 3.9X
Review Comment:
`subExprElimination true, codegen: true` and `subExprElimination true, codegen: false` have also significantly slowed down.
##########
sql/core/benchmarks/MetadataStructBenchmark-results.txt:
##########
@@ -2,39 +2,45 @@
Metadata Struct Benchmark
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vectorized Parquet: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-no metadata columns 486 513 20 10.3 97.2 1.0X
-_metadata.file_path 592 606 14 8.5 118.3 0.8X
-_metadata.file_name 582 592 8 8.6 116.5 0.8X
-_metadata.file_size 505 513 8 9.9 101.1 1.0X
-_metadata.file_modification_time 503 511 6 9.9 100.6 1.0X
-_metadata.row_index 587 598 9 8.5 117.4 0.8X
-_metadata 906 919 7 5.5 181.2 0.5X
+no metadata columns 572 628 34 8.7 114.5 1.0X
+_metadata.file_path 711 761 32 7.0 142.2 0.8X
+_metadata.file_name 718 751 22 7.0 143.7 0.8X
+_metadata.file_size 611 649 25 8.2 122.2 0.9X
+_metadata.file_block_start 589 622 20 8.5 117.8 1.0X
+_metadata.file_block_length 603 627 17 8.3 120.6 0.9X
+_metadata.file_modification_time 597 629 17 8.4 119.3 1.0X
+_metadata.row_index 678 708 22 7.4 135.5 0.8X
+_metadata 1219 1254 26 4.1 243.8 0.5X
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Parquet-mr: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-no metadata columns 1535 1557 15 3.3 307.1 1.0X
-_metadata.file_path 2056 2074 14 2.4 411.2 0.7X
-_metadata.file_name 2043 2064 19 2.4 408.7 0.8X
-_metadata.file_size 1846 1865 21 2.7 369.1 0.8X
-_metadata.file_modification_time 1845 1857 9 2.7 369.0 0.8X
-_metadata.row_index 1791 1811 15 2.8 358.1 0.9X
-_metadata 2689 2706 14 1.9 537.8 0.6X
+no metadata columns 3492 3570 32 1.4 698.4 1.0X
Review Comment:
This scenario has slowed down, perhaps it's related to the CPU model?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43065:
URL: https://github.com/apache/spark/pull/43065#discussion_r1334909865
##########
sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt:
##########
@@ -1,10 +1,10 @@
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
constructor: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-arrayOfAny 4 4 0 2491.5 0.4 1.0X
-arrayOfAnyAsObject 256 257 1 39.1 25.6 0.0X
-arrayOfAnyAsSeq 18 18 0 551.9 1.8 0.2X
-arrayOfInt 536 537 1 18.7 53.6 0.0X
-arrayOfIntAsObject 788 794 10 12.7 78.8 0.0X
+arrayOfAny 7 7 0 1495.4 0.7 1.0X
+arrayOfAnyAsObject 7 7 0 1495.3 0.7 1.0X
Review Comment:
The results of `arrayOfAnyAsSeq` have undergone significant changes and need attention (it may be a known issue, but I can't remember the details).
##########
sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt:
##########
@@ -1,10 +1,10 @@
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
constructor: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-arrayOfAny 4 4 0 2491.5 0.4 1.0X
-arrayOfAnyAsObject 256 257 1 39.1 25.6 0.0X
-arrayOfAnyAsSeq 18 18 0 551.9 1.8 0.2X
-arrayOfInt 536 537 1 18.7 53.6 0.0X
-arrayOfIntAsObject 788 794 10 12.7 78.8 0.0X
+arrayOfAny 7 7 0 1495.4 0.7 1.0X
+arrayOfAnyAsObject 7 7 0 1495.3 0.7 1.0X
Review Comment:
The results of `arrayOfAnyAsSeq` have undergone significant changes and need attention (it may be a known issue, but I can't remember the details).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43065:
URL: https://github.com/apache/spark/pull/43065#discussion_r1334908931
##########
core/benchmarks/ZStandardBenchmark-results.txt:
##########
@@ -2,26 +2,26 @@
Benchmark ZStandardCompressionCodec
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_372-b07 on Linux 5.15.0-1041-azure
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Benchmark ZStandardCompressionCodec: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------------------
-Compression 10000 times at level 1 without buffer pool 293 327 85 0.0 29283.2 1.0X
-Compression 10000 times at level 2 without buffer pool 322 324 2 0.0 32184.8 0.9X
-Compression 10000 times at level 3 without buffer pool 453 456 2 0.0 45285.1 0.6X
-Compression 10000 times at level 1 with buffer pool 171 173 1 0.1 17065.2 1.7X
-Compression 10000 times at level 2 with buffer pool 208 209 1 0.0 20786.5 1.4X
-Compression 10000 times at level 3 with buffer pool 334 335 2 0.0 33350.3 0.9X
+Compression 10000 times at level 1 without buffer pool 2800 2801 2 0.0 279995.2 1.0X
Review Comment:
From what I remember, the results of this microbenchmark are always unstable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43065:
URL: https://github.com/apache/spark/pull/43065#issuecomment-1732206126
Thank you for thorough reviews. Ya, we should catch up them one by one after having this. This helps us be in the same page and monitor this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43065:
URL: https://github.com/apache/spark/pull/43065#issuecomment-1732206610
I'll merge this because this PR doesn't touch any code. These are purely generated files as the snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
URL: https://github.com/apache/spark/pull/43065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43065: [SPARK-45287][TESTS] Add Java 21 benchmark result and update Java 17 ones
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43065:
URL: https://github.com/apache/spark/pull/43065#discussion_r1334911535
##########
sql/catalyst/benchmarks/GenericArrayDataBenchmark-results.txt:
##########
@@ -1,10 +1,10 @@
-OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure
-Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
+OpenJDK 64-Bit Server VM 17.0.8+7-LTS on Linux 5.15.0-1046-azure
+Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
constructor: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-arrayOfAny 4 4 0 2491.5 0.4 1.0X
-arrayOfAnyAsObject 256 257 1 39.1 25.6 0.0X
-arrayOfAnyAsSeq 18 18 0 551.9 1.8 0.2X
-arrayOfInt 536 537 1 18.7 53.6 0.0X
-arrayOfIntAsObject 788 794 10 12.7 78.8 0.0X
+arrayOfAny 7 7 0 1495.4 0.7 1.0X
+arrayOfAnyAsObject 7 7 0 1495.3 0.7 1.0X
+arrayOfAnyAsSeq 201 202 1 49.8 20.1 0.0X
Review Comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org