You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/15 18:05:19 UTC
[GitHub] [trafficserver] bryancall opened a new pull request #7005: Added tasks file for vscode, to configure and build ATS
bryancall opened a new pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455337723
##########
File path: .vscode/launch.json
##########
@@ -0,0 +1,27 @@
+{
+ // Use IntelliSense to learn about possible attributes.
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455349920
##########
File path: .vscode/tasks.json
##########
@@ -3,6 +3,20 @@
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
+ {
+ "label": "Autoreconf",
+ "type": "shell",
+ "command": "autoreconf -if",
+ "problemMatcher": []
+ },
+ {
+ "label": "Configure",
+ "type": "shell",
+ "command": "./configure --prefix=/opt/ats --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
Review comment:
@ezelkow1 I added the environment variable ATS_VSCODE_CONFIGURE, so you can override configuration options. It looks like the last option wins in autoconf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455281931
##########
File path: .vscode/tasks.json
##########
@@ -18,7 +18,7 @@
{
"label": "Configure",
"type": "shell",
- "command": "./configure --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
+ "command": "autoreconf -if; ./configure --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
Review comment:
👍 Yeah, I decided to do that and a few more things in the lasted commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] calavera commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
calavera commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455317929
##########
File path: .vscode/tasks.json
##########
@@ -3,6 +3,20 @@
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
+ {
+ "label": "Autoreconf",
+ "type": "shell",
+ "command": "autoreconf -if",
+ "problemMatcher": []
+ },
+ {
+ "label": "Configure",
+ "type": "shell",
+ "command": "./configure --prefix=/opt/ats --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
Review comment:
unless root access is absolutely necessary, I would not set the prefix in /opt. It also has the inconvenient of being global. I don't know if it's possible to use the workspace variable in this string, but something like `${workspaceFolder}/target` might be better.
This is not a strong opinion, so feel free to not change anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7005: Added tasks file for vscode, to configure and build ATS
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455268269
##########
File path: .vscode/tasks.json
##########
@@ -18,7 +18,7 @@
{
"label": "Configure",
"type": "shell",
- "command": "./configure --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
+ "command": "autoreconf -if; ./configure --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
Review comment:
A minor thing, but I suggest `&&` to separate the commands in case autoreconf fails for some reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#issuecomment-659503056
Ship it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455331481
##########
File path: .vscode/launch.json
##########
@@ -0,0 +1,27 @@
+{
+ // Use IntelliSense to learn about possible attributes.
Review comment:
can these comments be removed? They make this file invalid JSON
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455337658
##########
File path: .vscode/tasks.json
##########
@@ -3,6 +3,20 @@
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
+ {
+ "label": "Autoreconf",
+ "type": "shell",
+ "command": "autoreconf -if",
+ "problemMatcher": []
+ },
+ {
+ "label": "Configure",
+ "type": "shell",
+ "command": "./configure --prefix=/opt/ats --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
Review comment:
@ezelkow1 I am playing around with it to see if I can set an environment variable to override the default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#issuecomment-662688140
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on a change in pull request #7005: Added tasks and launch files for vscode, to configure, build and debug
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on a change in pull request #7005:
URL: https://github.com/apache/trafficserver/pull/7005#discussion_r455319637
##########
File path: .vscode/tasks.json
##########
@@ -3,6 +3,20 @@
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
+ {
+ "label": "Autoreconf",
+ "type": "shell",
+ "command": "autoreconf -if",
+ "problemMatcher": []
+ },
+ {
+ "label": "Configure",
+ "type": "shell",
+ "command": "./configure --prefix=/opt/ats --enable-ccache --enable-experimental-plugins --enable-example-plugins --enable-test-tools --enable-debug --enable-werror",
Review comment:
Id be +1 on some env variable for it if possible, we tend to generate everything to use /opt/trafficserver here, so having that be customizable would be good. Or maybe just have an optional env var insertion that people could throw in stuff like "--prefix=/your/ats/location --with-openssl=/your/ssl/location", so you can get custom things you use into the build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org