[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #408: Implement SAX Parsing

[GitBox <gi...@apache.org>]

olabusayoT commented on a change in pull request #408:
URL: https://github.com/apache/incubator-daffodil/pull/408#discussion_r483073460



##########
File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -1129,23 +1186,32 @@ case class ParserTestCase(ptc: NodeSeq, parentArg: DFDLTestSuite)
         firstParseResult.getBlobPaths.foreach { blobPath =>
           Files.delete(blobPath)
         }
+        firstParseResultSax.getBlobPaths.foreach { blobPath =>
+          Files.delete(blobPath)
+        }
       }
       case OnePassRoundTrip => {
         val outStream = new java.io.ByteArrayOutputStream()
+        val outStreamSax = new java.io.ByteArrayOutputStream()
 
         doOnePassRoundTripUnparseExpectSuccess(outStream, firstParseResult, implString)
+        doOnePassRoundTripUnparseExpectSuccess(outStreamSax, firstParseResultSax, implString)
 
         // It has to work, as this is one pass round trip. We expect it to unparse
         // directly back to the original input form.
 
         VerifyTestCase.verifyUnparserTestData(new ByteArrayInputStream(firstParseTestData), outStream, implString)
+        VerifyTestCase.verifyUnparserTestData(new ByteArrayInputStream(firstParseTestData), outStreamSax, implString)
 
         // Done with the first parse result, safe to clean up blobs if there
         // was success. This won't get called on failure, which is fine--leave
         // blobs around for debugging
         firstParseResult.getBlobPaths.foreach { blobPath =>
           Files.delete(blobPath)
         }
+        firstParseResultSax.getBlobPaths.foreach { blobPath =>
+          Files.delete(blobPath)
+        }
       }
       case TwoPassRoundTrip => {

Review comment:
       'sbt test' was only about 20 seconds longer when run with the 1763fb2d13eba1df5dacb44c560bd24010f35881D commit as the base. Will retest after the final rebase




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org