You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 17:58:06 UTC
[GitHub] [flink] dawidwys opened a new pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
dawidwys opened a new pull request #12232:
URL: https://github.com/apache/flink/pull/12232
## What is the purpose of the change
As per discussion here: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-TABLE-Issue-with-package-structure-in-the-Table-API-td37623.html
This PR:
* moves the scala expression DSL to org.apache.flink.table.api package in
table-api-scala module
* moves all classes from org.apache.flink.table.api.scala and
org.apache.flink.table.api.java packages to
org.apache.flink.table.api.bridge.scala and
org.apache.flink.table.api.bridge.java accordingly and drops the former
packages
**This is a breaking API change!!**
## Verifying this change
All the existing tests pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630805862
Thanks @dawidwys for the explanation. As I said above, if we decide to change it, and we have to do it, then we should do it in this release. So I'm fine with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630345422
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cffb27bb10c6d5da974483fbe8a32e562a0484e8 (Fri Oct 16 10:52:11 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630345422
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5925ef19171dea0dd42cd7f13875b7b05598f4b0 (Mon May 18 18:01:26 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
}, {
"hash" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6df9602ad51db30a39d5a8c6ed6e750025ff7429 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919)
* efc125913ce29720089ebc8ef13131da3c2fab8a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #12232:
URL: https://github.com/apache/flink/pull/12232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630345225
This change would break nearly all users setup. Nevertheless I think it is a very important change that significantly improves usability of the Table API.
Let me know what do you think about performing that change for 1.11. @aljoscha @twalthr @KurtYoung @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
}, {
"hash" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931",
"triggerID" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"triggerType" : "PUSH"
}, {
"hash" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"triggerType" : "PUSH"
}, {
"hash" : "cffb27bb10c6d5da974483fbe8a32e562a0484e8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cffb27bb10c6d5da974483fbe8a32e562a0484e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efc125913ce29720089ebc8ef13131da3c2fab8a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931)
* bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd UNKNOWN
* cffb27bb10c6d5da974483fbe8a32e562a0484e8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630636630
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630625826
Thanks for opening a PR for this topic @dawidwys. I wish we could avoid this but I don't see a possibility to prevent this change. The clash with the Scala macro and the annoying `_root_.scala` are very annoying API design fails that almost every user will observe eventually. Looking at the `WordCount` example shows easy and understandable imports now:
```
import org.apache.flink.table.api._
import org.apache.flink.table.api.bridge.scala._
```
And this is what we should aim for. Given that the user base is growing rapidly, we do this rather sooner than later. Given the amount of API that we have already changed, a simple update of the import line on the top is a rather easy change to apply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630774090
I think if we decide to change the package path, 1.11 is a good chance to do it, because we also change the execute() behavior in this version which forces users to update their programs. Otherwise, it might be impossible to do it in the future. The question is whether we should change it or not. This is really a tough decision (will break almost all the users program) :pensive:, is it worth to do it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630730443
This is a tough tradeoff but I think we need to break existing setups now in order to fix the problems that this causes. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5925ef19171dea0dd42cd7f13875b7b05598f4b0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767)
* 6df9602ad51db30a39d5a8c6ed6e750025ff7429 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
}, {
"hash" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931",
"triggerID" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6df9602ad51db30a39d5a8c6ed6e750025ff7429 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919)
* efc125913ce29720089ebc8ef13131da3c2fab8a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5925ef19171dea0dd42cd7f13875b7b05598f4b0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #12232:
URL: https://github.com/apache/flink/pull/12232#discussion_r427812311
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/expressions/package.scala
##########
@@ -21,8 +21,8 @@ package org.apache.flink.table
* This package contains the base class of AST nodes and all the expression language AST classes.
* Expression trees should not be manually constructed by users. They are implicitly constructed
* from the implicit DSL conversions in
- * [[org.apache.flink.table.api.scala.ImplicitExpressionConversions]] and
- * [[org.apache.flink.table.api.scala.ImplicitExpressionOperations]]. For the Java API,
+ * [[org.apache.flink.table.api.bridge.scala.ImplicitExpressionConversions]] and
+ * [[org.apache.flink.table.api.bridge.scala.ImplicitExpressionOperations]]. For the Java API,
Review comment:
Or shall I just remove this file? I don't see any reason for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-631324483
Thank you all for joining the discussion!
Thanks @twalthr for the review. I'll run the tests and after that I will merge that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
}, {
"hash" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931",
"triggerID" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"triggerType" : "PUSH"
}, {
"hash" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efc125913ce29720089ebc8ef13131da3c2fab8a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931)
* bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630789708
To give the discussion some time limit, if there are no objections (meaning people clearly against it) till tomorrow 10 am CEST I will introduce that change (if the release managers agree @pnowojski @zhijiangW).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6df9602ad51db30a39d5a8c6ed6e750025ff7429 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630787753
@wuchong My take is that it is inevitable at some point. With the current structure there are three issues:
1. users of the unified `TableEnvironment` have to depend on a bridging module for the expressionDsl
2. if users import `org.apache.flink.table.api._` they have to prefix all classes from `java` & `scala` with `_root_`
3. moreover in point 2. it breaks `TypeInformation` extraction for all such classes.
Therefore the question is rather if we do it now or in a next release...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #12232:
URL: https://github.com/apache/flink/pull/12232#discussion_r427791839
##########
File path: flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/package.scala
##########
@@ -39,7 +37,7 @@ import org.apache.flink.table.api.{ImplicitExpressionConversions, ImplicitExpres
*
* Please refer to the website documentation about how to construct and run table programs.
*/
-package object api /* extends ImplicitExpressionConversions */ {
+package object api extends ImplicitExpressionConversions {
// This package object should extend from ImplicitExpressionConversions but would clash with
Review comment:
update comment
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/expressions/package.scala
##########
@@ -21,8 +21,8 @@ package org.apache.flink.table
* This package contains the base class of AST nodes and all the expression language AST classes.
* Expression trees should not be manually constructed by users. They are implicitly constructed
* from the implicit DSL conversions in
- * [[org.apache.flink.table.api.scala.ImplicitExpressionConversions]] and
- * [[org.apache.flink.table.api.scala.ImplicitExpressionOperations]]. For the Java API,
+ * [[org.apache.flink.table.api.bridge.scala.ImplicitExpressionConversions]] and
+ * [[org.apache.flink.table.api.bridge.scala.ImplicitExpressionOperations]]. For the Java API,
Review comment:
update last sentence
##########
File path: flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/expressionDsl.scala
##########
@@ -33,7 +33,7 @@ import java.sql.{Date, Time, Timestamp}
import java.time.{LocalDate, LocalDateTime, LocalTime}
import java.util.{List => JList, Map => JMap}
Review comment:
nit: Shall we move `ImplicitExpressionConversions` and `ImplicitExpressionOperations` into dedicated files? Personally, I don't like `expressionDsl.scala` much. `TableConversions` and `DataStreamConvertions` are also dedicated files.
##########
File path: docs/dev/table/common.md
##########
@@ -552,7 +552,9 @@ val revenue = orders
// execute query
{% endhighlight %}
-**Note:** The Scala Table API uses Scala Symbols, which start with a single tick (`'`) to reference the attributes of a `Table`. The Table API uses Scala implicits. Make sure to import `org.apache.flink.api.scala._` and `org.apache.flink.table.api.scala._` in order to use Scala implicit conversions.
+**Note:** The Scala Table API uses Scala Symbols, which start with a single tick (`'`) to reference the attributes of a `Table`. The Table API uses Scala implicits. Make sure to import
Review comment:
`The Scala Table API uses Scala Symbols, which start with a single tick (`'`)`, update?
##########
File path: flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala
##########
@@ -23,7 +23,7 @@ import org.apache.flink.api.java.{JarHelper, ScalaShellEnvironment, ScalaShellSt
import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
import org.apache.flink.configuration.Configuration
import org.apache.flink.table.api.EnvironmentSettings
-import org.apache.flink.table.api.scala.{BatchTableEnvironment, StreamTableEnvironment}
+import org.apache.flink.table.api.bridge.scala.{BatchTableEnvironment, StreamTableEnvironment}
Review comment:
Update the default imports in the lower part of this class.
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/package.scala
##########
@@ -50,7 +50,7 @@ import _root_.scala.language.implicitConversions
* Please refer to the website documentation about how to construct and run table programs that are
* connected to the DataStream API.
*/
-package object scala extends ImplicitExpressionConversions {
+package object scala {
// This package object should not extend from ImplicitExpressionConversions but would clash with
Review comment:
update comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5925ef19171dea0dd42cd7f13875b7b05598f4b0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767)
* 6df9602ad51db30a39d5a8c6ed6e750025ff7429 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
}, {
"hash" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931",
"triggerID" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"triggerType" : "PUSH"
}, {
"hash" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"triggerType" : "PUSH"
}, {
"hash" : "cffb27bb10c6d5da974483fbe8a32e562a0484e8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1936",
"triggerID" : "cffb27bb10c6d5da974483fbe8a32e562a0484e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efc125913ce29720089ebc8ef13131da3c2fab8a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931)
* bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd UNKNOWN
* cffb27bb10c6d5da974483fbe8a32e562a0484e8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1936)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5925ef19171dea0dd42cd7f13875b7b05598f4b0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5925ef19171dea0dd42cd7f13875b7b05598f4b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12232:
URL: https://github.com/apache/flink/pull/12232#issuecomment-630355116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1767",
"triggerID" : "5925ef19171dea0dd42cd7f13875b7b05598f4b0",
"triggerType" : "PUSH"
}, {
"hash" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1919",
"triggerID" : "6df9602ad51db30a39d5a8c6ed6e750025ff7429",
"triggerType" : "PUSH"
}, {
"hash" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1931",
"triggerID" : "efc125913ce29720089ebc8ef13131da3c2fab8a",
"triggerType" : "PUSH"
}, {
"hash" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd",
"triggerType" : "PUSH"
}, {
"hash" : "cffb27bb10c6d5da974483fbe8a32e562a0484e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1936",
"triggerID" : "cffb27bb10c6d5da974483fbe8a32e562a0484e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bde94ff2e28c3b8d1b9e2b25c38afa24f8a558fd UNKNOWN
* cffb27bb10c6d5da974483fbe8a32e562a0484e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1936)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org