You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/25 07:46:15 UTC

Review Request 46624: Added support to mesos to work with flag alias.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46624/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-5271
    https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
-------

Added support to mesos to work with flag alias.


Diffs
-----

  src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
  src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e 

Diff: https://reviews.apache.org/r/46624/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 46624: Added support to mesos to work with flag alias.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46624/#review130368
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46620, 46621, 46622, 46623, 46624]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 5:46 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46624/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:46 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
>     https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support to mesos to work with flag alias.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e 
> 
> Diff: https://reviews.apache.org/r/46624/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 46624: Added support to mesos to work with flag alias.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46624/
-----------------------------------------------------------

(Updated April 30, 2016, 3:43 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-5271
    https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
-------

Added support to mesos to work with flag alias.


Diffs (updated)
-----

  src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
  src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 

Diff: https://reviews.apache.org/r/46624/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 46624: Added support to mesos to work with flag alias.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46624/
-----------------------------------------------------------

(Updated April 29, 2016, 3:27 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

rebased.


Bugs: MESOS-5271
    https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
-------

Added support to mesos to work with flag alias.


Diffs (updated)
-----

  src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
  src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 

Diff: https://reviews.apache.org/r/46624/diff/


Testing
-------

make check


Thanks,

Vinod Kone