You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/07/14 13:02:37 UTC
Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/
-----------------------------------------------------------
Review request for sentry and Sergio Pena.
Bugs: SENTRY-1834
https://issues.apache.org/jira/browse/SENTRY-1834
Repository: sentry
Description
-------
Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
2. Hive BindingV2 will not be green.
Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
Diffs
-----
pom.xml 2c109a4
sentry-binding/pom.xml 71fe47c
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
sentry-dist/pom.xml 2d7f57e
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
Diff: https://reviews.apache.org/r/60865/diff/1/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On July 14, 2017, 3:49 p.m., Colm O hEigeartaigh wrote:
> > Is there a reason the PMD failOnViolation flag has changed to false?
There were a lot of failures because of that. To maintain the focus of this patch I had to supress PMD violations. I will open another jira to fix the PMD violations.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180534
-----------------------------------------------------------
On July 14, 2017, 3:31 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 3:31 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On July 14, 2017, 3:49 p.m., Colm O hEigeartaigh wrote:
> > Is there a reason the PMD failOnViolation flag has changed to false?
>
> kalyan kumar kalvagadda wrote:
> There were a lot of failures because of that. To maintain the focus of this patch I had to supress PMD violations. I will open another jira to fix the PMD violations.
In the Hive v2 binding module? If so it'd be better just to disable PMD for that particular module, by setting the pmd.skip property to true in a profile activated by default.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180534
-----------------------------------------------------------
On July 14, 2017, 3:31 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 3:31 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On July 14, 2017, 3:49 p.m., Colm O hEigeartaigh wrote:
> > Is there a reason the PMD failOnViolation flag has changed to false?
>
> kalyan kumar kalvagadda wrote:
> There were a lot of failures because of that. To maintain the focus of this patch I had to supress PMD violations. I will open another jira to fix the PMD violations.
>
> Colm O hEigeartaigh wrote:
> In the Hive v2 binding module? If so it'd be better just to disable PMD for that particular module, by setting the pmd.skip property to true in a profile activated by default.
I did not know it can be done that way. I will make the change. Otherwise what do you say about the patch?
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180534
-----------------------------------------------------------
On July 14, 2017, 3:31 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 3:31 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180534
-----------------------------------------------------------
Is there a reason the PMD failOnViolation flag has changed to false?
- Colm O hEigeartaigh
On July 14, 2017, 3:31 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 3:31 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180673
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 17, 2017, 12:52 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 12:52 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Made code changes to fix the compilation issues when hive-authz2 profile is enabled.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-tests/pom.xml 1909dae
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Brian Towles <bt...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180860
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Towles
On July 17, 2017, 7:52 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 7:52 a.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Made code changes to fix the compilation issues when hive-authz2 profile is enabled.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-tests/pom.xml 1909dae
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/
-----------------------------------------------------------
(Updated July 17, 2017, 12:52 p.m.)
Review request for sentry and Sergio Pena.
Changes
-------
Changed the scope of patch. see description
Bugs: SENTRY-1834
https://issues.apache.org/jira/browse/SENTRY-1834
Repository: sentry
Description (updated)
-------
Made code changes to fix the compilation issues when hive-authz2 profile is enabled.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
sentry-tests/pom.xml 1909dae
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
Diff: https://reviews.apache.org/r/60865/diff/4/
Changes: https://reviews.apache.org/r/60865/diff/3-4/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180587
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 14, 2017, 6:34 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 6:34 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/pom.xml 1909dae
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
>
>
> Diff: https://reviews.apache.org/r/60865/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/
-----------------------------------------------------------
(Updated July 14, 2017, 6:34 p.m.)
Review request for sentry and Sergio Pena.
Changes
-------
Added changes to ignote pmd violations for a specific package
Bugs: SENTRY-1834
https://issues.apache.org/jira/browse/SENTRY-1834
Repository: sentry
Description
-------
Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
2. Hive BindingV2 will not be green.
Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
Diffs (updated)
-----
sentry-binding/pom.xml 71fe47c
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
sentry-dist/pom.xml 2d7f57e
sentry-tests/pom.xml 1909dae
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
Diff: https://reviews.apache.org/r/60865/diff/3/
Changes: https://reviews.apache.org/r/60865/diff/2-3/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/
-----------------------------------------------------------
(Updated July 14, 2017, 3:31 p.m.)
Review request for sentry and Sergio Pena.
Changes
-------
Colm, Made changes as per your comments.
Bugs: SENTRY-1834
https://issues.apache.org/jira/browse/SENTRY-1834
Repository: sentry
Description
-------
Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
2. Hive BindingV2 will not be green.
Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
Diffs (updated)
-----
pom.xml 2c109a4
sentry-binding/pom.xml 71fe47c
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
sentry-dist/pom.xml 2d7f57e
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
Diff: https://reviews.apache.org/r/60865/diff/2/
Changes: https://reviews.apache.org/r/60865/diff/1-2/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On July 14, 2017, 1:08 p.m., Colm O hEigeartaigh wrote:
> > I think this is not against the latest source, as I already fixed the test compilation issue in sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java on that branch.
Ohh right, I have created this patch two ago. I saw your commit yesterday. I will update the patch and submitit again.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180521
-----------------------------------------------------------
On July 14, 2017, 1:02 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 1:02 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
>
>
> Diff: https://reviews.apache.org/r/60865/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On July 14, 2017, 1:08 p.m., Colm O hEigeartaigh wrote:
> > I think this is not against the latest source, as I already fixed the test compilation issue in sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java on that branch.
>
> kalyan kumar kalvagadda wrote:
> Ohh right, I have created this patch two ago. I saw your commit yesterday. I will update the patch and submitit again.
>
> Colm O hEigeartaigh wrote:
> Great thanks! I also wonder if there's any point in keeping the separate hive profiles, if they are both being built by default?
>
> kalyan kumar kalvagadda wrote:
> Both the profile are getting build but not tested. sentry-tests-hive-v2 will not be tested.
What I meant was to remove the profiles in the sentry-binding pom + just include both hive bindings as normal in the module list. The profiles can stay in the sentry-tests pom until the tests are fixed.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180521
-----------------------------------------------------------
On July 14, 2017, 1:02 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 1:02 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
>
>
> Diff: https://reviews.apache.org/r/60865/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On July 14, 2017, 1:08 p.m., Colm O hEigeartaigh wrote:
> > I think this is not against the latest source, as I already fixed the test compilation issue in sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java on that branch.
>
> kalyan kumar kalvagadda wrote:
> Ohh right, I have created this patch two ago. I saw your commit yesterday. I will update the patch and submitit again.
Great thanks! I also wonder if there's any point in keeping the separate hive profiles, if they are both being built by default?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180521
-----------------------------------------------------------
On July 14, 2017, 1:02 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 1:02 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
>
>
> Diff: https://reviews.apache.org/r/60865/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On July 14, 2017, 1:08 p.m., Colm O hEigeartaigh wrote:
> > I think this is not against the latest source, as I already fixed the test compilation issue in sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java on that branch.
>
> kalyan kumar kalvagadda wrote:
> Ohh right, I have created this patch two ago. I saw your commit yesterday. I will update the patch and submitit again.
>
> Colm O hEigeartaigh wrote:
> Great thanks! I also wonder if there's any point in keeping the separate hive profiles, if they are both being built by default?
>
> kalyan kumar kalvagadda wrote:
> Both the profile are getting build but not tested. sentry-tests-hive-v2 will not be tested.
>
> Colm O hEigeartaigh wrote:
> What I meant was to remove the profiles in the sentry-binding pom + just include both hive bindings as normal in the module list. The profiles can stay in the sentry-tests pom until the tests are fixed.
Agree, i have a patch accordingly.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180521
-----------------------------------------------------------
On July 14, 2017, 1:02 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 1:02 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
>
>
> Diff: https://reviews.apache.org/r/60865/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On July 14, 2017, 1:08 p.m., Colm O hEigeartaigh wrote:
> > I think this is not against the latest source, as I already fixed the test compilation issue in sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java on that branch.
>
> kalyan kumar kalvagadda wrote:
> Ohh right, I have created this patch two ago. I saw your commit yesterday. I will update the patch and submitit again.
>
> Colm O hEigeartaigh wrote:
> Great thanks! I also wonder if there's any point in keeping the separate hive profiles, if they are both being built by default?
Both the profile are getting build but not tested. sentry-tests-hive-v2 will not be tested.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180521
-----------------------------------------------------------
On July 14, 2017, 1:02 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 1:02 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
>
>
> Diff: https://reviews.apache.org/r/60865/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 60865: SENTRY-1834 Enable hive-authv2 profile in
sentry-ha-redesign branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180521
-----------------------------------------------------------
I think this is not against the latest source, as I already fixed the test compilation issue in sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java on that branch.
- Colm O hEigeartaigh
On July 14, 2017, 1:02 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60865/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 1:02 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1834
> https://issues.apache.org/jira/browse/SENTRY-1834
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch.
> As we are supporting hive auth V2 in that branch we need to keep it up to date. Disabling it is making the Hive-Authv2 binding implementation stale. Here are some os the issue disabling it.
> 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed.
> 2. Hive BindingV2 will not be green.
> Fixing would be a bigger issue. If they are enabled contributors will make sure that related cpde for Hive-Authv2 is also fixed/updated properly.
>
>
> Diffs
> -----
>
> pom.xml 2c109a4
> sentry-binding/pom.xml 71fe47c
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java c63cf64
> sentry-dist/pom.xml 2d7f57e
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 1415297
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java 8818c4c
>
>
> Diff: https://reviews.apache.org/r/60865/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>