You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by "hufeng@apache" <hu...@apache.org> on 2019/12/06 15:18:07 UTC

[VOTE]: Release Apache dubbo-js v3.0.0-rc2

Hello Dubbo/Dubbojs Community,

This is a call for vote to release Apache dubbo-js version v3.0.0-rc2.

The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/

Git tag for the release:
https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md

Hash for the release tag:
b612e051ec1c9df8e4be510cda6d33c0d74c963d

The artifacts have been signed with Key :35F44C444B811C10, which can be
found in the keys file:

 https://dist.apache.org/repos/dist/dev/dubbo/KEYS

 The vote will be open for at least 72 hours or until necessary number of
votes are reached.


 Please vote accordingly:

 [ ] +1 approve

 [ ] +0 no opinion

 [ ] -1 disapprove with the reason


 Thanks,

 The Apache Dubbo-js Team

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
HI,

Sorry but it’s -1 (binding) due to compile code in release [1][2] and file not have correct asf headers

I checked:
- Signatures and hashes fine
- LICENSE and NOTICE are fine
- Compiled code exist in the release [1][2]
- Some java files are missing ASF headers e.g [3] (there about a dozen files like this)
- Some files I assume have incorrect ASF headers with a copyright line "Copyright 1999-2011 Alibaba Group.”, This code was donated to the ASF right?

I also notice that the package name for some of the Java files is "com/alibaba” should this be something different? I also noticed this pom file [4] states the code is Copyright Alibaba Group

Thanks,
Justin

1. ./packages/interpret-cli/ext/jexpose-1.2.jar
2. ./packages/interpret-cli/ext/jexpose-1.3.jar
3. ./java/dubbo-demo/dubbo-demo-api/src/main/java/com/alibaba/dubbo/demo/BasicTypeProvider.java
4. ./java/pom.xml