[GitHub] [pinot] klsince commented on a diff in pull request #9540: get task runtime configs tracked in Helix

[GitBox <gi...@apache.org>]

klsince commented on code in PR #9540:
URL: https://github.com/apache/pinot/pull/9540#discussion_r988428508


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##########
@@ -386,7 +386,15 @@ public Map<String, TaskPartitionState> getSubtaskStates(
   @ApiOperation("Get the task config (a list of child task configs) for the given task")
   public List<PinotTaskConfig> getTaskConfigs(
       @ApiParam(value = "Task name", required = true) @PathParam("taskName") String taskName) {
-    return _pinotHelixTaskResourceManager.getTaskConfigs(taskName);
+    return _pinotHelixTaskResourceManager.getSubtaskConfigs(taskName);
+  }
+
+  @GET
+  @Path("/tasks/task/{taskName}/runtime/config")
+  @ApiOperation("Get the task runtime config for the given task")
+  public Map<String, String> getTaskConfig(

Review Comment:
   I'd prefer a separate API, in case any applications are assuming a List<PinotTaskConfig> returned by the old API. (if we have versioned our APIs with prefix like v1/v2, I'd save a lot of time to come up with a new name :p) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org