You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/06 17:31:28 UTC

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36082: [SPARK-38760][PYTHON][SQL][SS] Add DataFrame.observe(str, ...) for Structured Streaming in PySpark

xinrong-databricks commented on code in PR #36082:
URL: https://github.com/apache/spark/pull/36082#discussion_r844207779


##########
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala:
##########
@@ -37,7 +38,10 @@ import org.apache.spark.sql.internal.SQLConf
 import org.apache.spark.sql.types.DataType
 
 private[sql] object PythonSQLUtils extends Logging {
-  private lazy val rowPickler = new Pickler(true, false)
+  private lazy val internalrowPickler = {

Review Comment:
   nit: internal**R**owPickler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org