You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2013/07/26 23:32:58 UTC

svn commit: r1507471 - /commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java

Author: britter
Date: Fri Jul 26 21:32:58 2013
New Revision: 1507471

URL: http://svn.apache.org/r1507471
Log:
No need to define valid email addresses here. The same addresses are already defined in base class.

Modified:
    commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java

Modified: commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java?rev=1507471&r1=1507470&r2=1507471&view=diff
==============================================================================
--- commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java (original)
+++ commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java Fri Jul 26 21:32:58 2013
@@ -319,12 +319,6 @@ public class EmailTest extends AbstractE
         // ====================================================================
         // Test Success
         // ====================================================================
-        String[] testEmails =
-        {
-            "me@home.com",
-            "joe.doe@apache.org",
-            "someone_here@work-address.com.au"
-        };
         String[] testEmailNames = {"Name1", "", null};
         List<InternetAddress> arrExpected = new ArrayList<InternetAddress>();
         arrExpected.add(new InternetAddress("me@home.com", "Name1"));
@@ -337,10 +331,10 @@ public class EmailTest extends AbstractE
                         "someone_here@work-address.com.au",
                         "someone_here@work-address.com.au"));
 
-        for (int i = 0; i < testEmails.length; i++)
+        for (int i = 0; i < ARR_VALID_EMAILS.length; i++)
         {
             // set from
-            this.email.setFrom(testEmails[i], testEmailNames[i]);
+            this.email.setFrom(ARR_VALID_EMAILS[i], testEmailNames[i]);
 
             // retrieve and verify
             assertEquals(arrExpected.get(i), this.email.getFromAddress());