You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wayneguow (via GitHub)" <gi...@apache.org> on 2024/07/12 12:04:14 UTC
[PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
wayneguow opened a new pull request, #47327:
URL: https://github.com/apache/spark/pull/47327
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to assign names to streaming output mode related error classes:
- _LEGACY_ERROR_TEMP_1131 -> INVALID_STREAMING_OUTPUT_MODE.UNKNOWN
- _LEGACY_ERROR_TEMP_3261 -> INVALID_STREAMING_OUTPUT_MODE.UNKNOWN
- _LEGACY_ERROR_TEMP_2211 -> INVALID_STREAMING_OUTPUT_MODE.NOT_SUPPORTED_IN_FILE_SINK
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Proper error names and messages improve user experience with SS.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, this PR changes user-facing error class and message.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Pass GA and add a new test case.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #47327:
URL: https://github.com/apache/spark/pull/47327#issuecomment-2227995067
cc @yaooqinn @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1675756241
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1750,11 +1750,10 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
}
def invalidStreamingOutputModeError(
Review Comment:
Currently, there is no way to add test cases related to this error class.
Because in the two places(`StateStoreSaveExec` and `SessionWindowStateStoreSaveExec`) where exceptions are thrown, output mode param is already of `OutputMode` type, and an empty assert check is added to the run method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1683979794
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1750,11 +1750,10 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
}
def invalidStreamingOutputModeError(
Review Comment:
I think this exception isn't generalized enough yet.
This now does not happen at all (since _LEGACY_ERROR_TEMP_3261 has to happen first) so it wasn't an issue, but if we deduce the meaningful error class from this, this should probably need to couple with operator, and provide the operator information as well, something along the line with this `"<operator Name> does not support <outputMode> output mode."`
Here, `<operator name>` has to be user friendly, e.g. "Streaming aggregation", not StateStoreSaveExec or so. Same for "Streaming session window aggregation", etc.
After that, it could be bound to INVALID_STREAMING_OUTPUT_MODE.UNSUPPORTED_OPERATOR. Conceptually it has to be flipped, but if we really want to group these error classes into INVALID_STREAMING_OUTPUT_MODE. If we don't group and just flip, STREAMING_OPERATOR_UNSUPPORTED_OUTPUT_MODE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1683979794
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1750,11 +1750,10 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
}
def invalidStreamingOutputModeError(
Review Comment:
I think this exception isn't generalized enough yet.
This now does not happen at all (since _LEGACY_ERROR_TEMP_3261 has to happen first) so it wasn't an issue, but if we deduce the meaningful error class from this, this should probably need to couple with operator, and provide the operator information as well, something along the line with this `"<operator Name> does not support <outputMode> output mode."`
Here, `<operator name>` has to be user friendly, e.g. "Streaming aggregation", not StateStoreSaveExec or so. Same for "Streaming session window aggregation", etc.
After that, it could be bound to INVALID_STREAMING_OUTPUT_MODE.UNSUPPORTED_OPERATOR. Conceptually it has to be flipped, but if we really want to group these error classes into INVALID_STREAMING_OUTPUT_MODE. If we flip, STREAMING_OPERATOR_UNSUPPORTED_OUTPUT_MODE.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1594,13 +1596,11 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat
messageParameters = Map("path" -> path))
}
- def dataSourceOutputModeUnsupportedError(
- className: String, outputMode: OutputMode): Throwable = {
+ def fileSinkOutputModeUnsupportedError(
Review Comment:
Shall we just leave the error class as same to cover arbitrary data source? Users are more friendly to the sink format they provide, e.g. parquet, etc. Also it can be used from any future data source if we leave flexibility.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1594,13 +1596,11 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat
messageParameters = Map("path" -> path))
}
- def dataSourceOutputModeUnsupportedError(
- className: String, outputMode: OutputMode): Throwable = {
+ def fileSinkOutputModeUnsupportedError(
Review Comment:
If it's not weird to have INVALID_STREAMING_OUTPUT_MODE.UNSUPPORTED_OPERATOR, this can be INVALID_STREAMING_OUTPUT_MODE.UNSUPPORTED_DATA_SOURCE. But again, this has to be flipped, like `DATA_SOURCE_UNSUPPORTED_STREAMING_OUTPUT_MODE`. (If there is a general error class group for data source, include there.)
Probably it might not be good to group them with INVALID_STREAMING_OUTPUT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #47327:
URL: https://github.com/apache/spark/pull/47327#issuecomment-2228019882
also cc @HeartSaVioR FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #47327: [SPARK-48882][SS] Assign names to streaming output mode related error classes
URL: https://github.com/apache/spark/pull/47327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1684088487
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1594,13 +1596,11 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat
messageParameters = Map("path" -> path))
}
- def dataSourceOutputModeUnsupportedError(
- className: String, outputMode: OutputMode): Throwable = {
+ def fileSinkOutputModeUnsupportedError(
Review Comment:
Thank you for your very insightful suggestions, let me make some improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1717134008
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4144,6 +4144,29 @@
],
"sqlState" : "42601"
},
+ "STREAMING_OUTPUT_MODE" : {
Review Comment:
> @MaxGekk Do we happen to have similar case, and if we had how did we deal with it?
We had, for instance:
https://github.com/apache/spark/blob/02795a36171cac51b1beaf68c42e8dfe3e6f0903/common/utils/src/main/resources/error/error-conditions.json#L653-L663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1683979794
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1750,11 +1750,10 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
}
def invalidStreamingOutputModeError(
Review Comment:
I think this exception isn't generalized enough yet.
This now does not happen at all (since _LEGACY_ERROR_TEMP_3261 has to happen first) so it wasn't an issue, but if we deduce the meaningful error class from this, this should probably need to couple with operator, and provide the operator information as well, something along the line with this `"<operator Name> does not support <outputMode> output mode."`
Here, `<operator name>` has to be user friendly, e.g. "Streaming aggregation", not StateStoreSaveExec or so. Same for "Streaming session window aggregation", etc.
After that, it could be bound to INVALID_STREAMING_OUTPUT_MODE.UNSUPPORTED_OPERATOR. Conceptually it has to be flipped, but if we really want to group these error classes into INVALID_STREAMING_OUTPUT_MODE. If we don't group and just want to have (flipped) separate error class, STREAMING_OPERATOR_UNSUPPORTED_OUTPUT_MODE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #47327:
URL: https://github.com/apache/spark/pull/47327#issuecomment-2277617782
also cc @MaxGekk , thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1717083786
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4144,6 +4144,29 @@
],
"sqlState" : "42601"
},
+ "STREAMING_OUTPUT_MODE" : {
Review Comment:
nit: Shall we start with `INVALID_`? I know you want to put this in subclass, but the general error message does not go with general error class.
@MaxGekk Do we happen to have similar case, and if we had how did we deal with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1716846820
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4830,6 +4842,12 @@
},
"sqlState" : "42K0E"
},
+ "UNSUPPORTED_OUTPUT_MODE_FOR_STREAMING_OPERATION" : {
Review Comment:
@MaxGekk I updated the name of the error classes as suggested. Please take a look again when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1690726869
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1594,13 +1596,11 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat
messageParameters = Map("path" -> path))
}
- def dataSourceOutputModeUnsupportedError(
- className: String, outputMode: OutputMode): Throwable = {
+ def fileSinkOutputModeUnsupportedError(
Review Comment:
I have updated according to the review. Please take a look when you have time. @HeartSaVioR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1716435028
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4830,6 +4842,12 @@
},
"sqlState" : "42K0E"
},
+ "UNSUPPORTED_OUTPUT_MODE_FOR_STREAMING_OPERATION" : {
Review Comment:
All the touched error conditions are related to streaming output mode. Let's create the `STREAMING_OUTPUT_MODE` error condition with sub-classes: `UNSUPPORTED_DATASOURCE`, `INVALID` and `UNSUPPORTED_OPERATION`. The error text of `STREAMING_OUTPUT_MODE` shall point out the invalid mode, and sub-classes should provide some details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1718394280
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4144,6 +4144,29 @@
],
"sqlState" : "42601"
},
+ "STREAMING_OUTPUT_MODE" : {
Review Comment:
I don't have strong argument for this. What I am saying is the general message of the top-class is already denoting "invalid" output mode, so subclasses are expected to be a case of "invalid", not others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48882][SS] Assign names to streaming output mode related error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #47327:
URL: https://github.com/apache/spark/pull/47327#discussion_r1718102702
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4144,6 +4144,29 @@
],
"sqlState" : "42601"
},
+ "STREAMING_OUTPUT_MODE" : {
Review Comment:
@HeartSaVioR I believe it is not necessary to add the prefixes like `ERROR`, `INVALID`, `FAILED` everywhere especially in this particular case. It should be clear to users that we deal with error situation/condition, so, in our case the condition is `streaming + output mode`. And details like `INVALID`, `NOT_SUPPORTED` are in sub-classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org