You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Matthias Wessendorf <ma...@apache.org> on 2009/05/01 13:06:28 UTC

Re: [TRINIDAD] Allow redefinition of the RequestContextFactory

not sure why it was done. The code was never really touched within the
last two years..

Perhaps Blake or Andy know ? :)

On Thu, Apr 30, 2009 at 7:33 PM, Simon Lessard
<si...@gmail.com> wrote:
> Hi,
>
> Currently Trinidad won't allow to redefine the RequestContextFactory once
> it's defined, preventing any attempt to decorate it. Would it be ok with you
> if I removed that check?
>
>
> Regards,
>
> ~ Simon
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Re: [TRINIDAD] Allow redefinition of the RequestContextFactory

Posted by Simon Lessard <si...@gmail.com>.
Yeah PartialPageContextImpl does, I'll try to find the best possible design,
I don't really like moving methods to public API unless they really have to
be there. I'll work on that this weekend most likely, along with some 2.0
tasks.


~ Simon

On Fri, May 1, 2009 at 1:12 PM, Blake Sullivan <bl...@oracle.com>wrote:

>  Does any of the impl code cast the RequestContext to the
> RequestContextImpl?  If it does, that would be the reason.
>
> -- Blake
>
> Matthias Wessendorf said the following On 5/1/2009 4:06 AM PT:
>
> not sure why it was done. The code was never really touched within the
> last two years..
>
> Perhaps Blake or Andy know ? :)
>
> On Thu, Apr 30, 2009 at 7:33 PM, Simon Lessard<si...@gmail.com> <si...@gmail.com> wrote:
>
>
>  Hi,
>
> Currently Trinidad won't allow to redefine the RequestContextFactory once
> it's defined, preventing any attempt to decorate it. Would it be ok with you
> if I removed that check?
>
>
> Regards,
>
> ~ Simon
>
>
>
>
>

Re: [TRINIDAD] Allow redefinition of the RequestContextFactory

Posted by Blake Sullivan <bl...@oracle.com>.
Does any of the impl code cast the RequestContext to the 
RequestContextImpl?  If it does, that would be the reason.

-- Blake

Matthias Wessendorf said the following On 5/1/2009 4:06 AM PT:
> not sure why it was done. The code was never really touched within the
> last two years..
>
> Perhaps Blake or Andy know ? :)
>
> On Thu, Apr 30, 2009 at 7:33 PM, Simon Lessard
> <si...@gmail.com> wrote:
>   
>> Hi,
>>
>> Currently Trinidad won't allow to redefine the RequestContextFactory once
>> it's defined, preventing any attempt to decorate it. Would it be ok with you
>> if I removed that check?
>>
>>
>> Regards,
>>
>> ~ Simon
>>
>>     
>
>
>
>