Re: Apache::SizeLimit snaffoo?

["Philip M. Gollucci" <pg...@p6m7g8.com>]

Simon Luff wrote:
> Howdy,
> 
> Not sure if this is the right place to report an issue with
> Apache::SizeLimit or not. I'm not on the mailing lists and the doc
> seemed to suggest that 0.9 was maintained outside of mod_perl, but I'll
> send it in the hope someone finds it useful.
> 
> best regards,
> Simon.
> 
> -------- Original Message --------
> Subject: Re: Apache::SizeLimit snaffoo?
> Date: Fri, 11 Aug 2006 07:36:36 -0500 (CDT)
> From: Dave Rolsky <au...@urth.org>
> To: Simon Luff <si...@coreware.co.uk>
> References: <44...@coreware.co.uk>
> 
> Could you mail this to the modperl dev list - dev@perl.apache.org?
> 
> That's where we discuss bugs and maintenance of this module.
> 
> On Fri, 11 Aug 2006, Simon Luff wrote:
> 
>> Hi Dave,
>>
>> We run a patched version 0.03 of Apache::SizeLimit here, so I haven't
>> actually run the 0.9 version.
>>
>> Doesn't it suffer from the same problem that I've patched in ours? The
>> initialisation of variables at run time and the conditional setting of
>> them at compile time?
>>
>> In the 0.9 I just browsed the source of, the variable $USE_SMAPS is
>> declared in use vars, then is conditionally set in a BEGIN block
>> towards the bottom of the code, and then is unconditionally
>> "initialised" to 1 at the beginning of runtime.
>>
>> Isn't that broken?
You are correct.  I've just committed 433945.

But... that doesn't help you just yet, as trunk is unstable due to the mp1/mp2 hybridization I just started tonight also.

I suppose I could move /tags/stable to /branches/stable and apply it there along with the one other
fix: http://svn.apache.org/viewvc?rev=433879&view=rev

I'm pretty sure that branch is going to be deleted once trunk is stable again anway.

Thoughts anyone ?



-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /
 / /|_/ / // /\ \/ /_/ / /__
/_/  /_/\_, /___/\___\_\___/
       <___/