You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "nao-it (via GitHub)" <gi...@apache.org> on 2026/06/23 09:57:22 UTC
[PR] IGNITE-28765 update Jetty [ignite]
nao-it opened a new pull request, #13269:
URL: https://github.com/apache/ignite/pull/13269
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28765 update Jetty [ignite]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv closed pull request #13269: IGNITE-28765 update Jetty
URL: https://github.com/apache/ignite/pull/13269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28765 update Jetty [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on code in PR #13269:
URL: https://github.com/apache/ignite/pull/13269#discussion_r3474605926
##########
examples/src/main/java/org/apache/ignite/examples/misc/springbean/SpringBeanExample.java:
##########
@@ -83,7 +83,7 @@ public static void main(String[] args) throws Exception {
}
finally {
// Stop local cluster node.
- ctx.destroy();
+ ctx.close();
Review Comment:
try with resources?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java:
##########
@@ -1017,6 +1017,11 @@ private void startHttpProtocol() throws IgniteCheckedException {
log.debug("Failed to initialize HTTP REST protocol (consider adding ignite-rest-http " +
"module to classpath).");
}
+ catch (LinkageError e) {
+ U.warn(log, "Failed to initialize HTTP REST protocol because a required dependency is missing " +
+ "from classpath (make sure the ignite-rest-http module libraries, e.g. jakarta.servlet-api, " +
Review Comment:
plz change this desc
##########
modules/calcite/pom.xml:
##########
@@ -69,6 +69,12 @@
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<version>${calcite.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.transaction</groupId>
+ <artifactId>jakarta.transaction-api</artifactId>
Review Comment:
may be we can eclude org.apache.commons:commons-dbcp2 ?
##########
modules/spring/src/main/java/org/apache/ignite/internal/processors/resource/GridResourceSpringBeanInjector.java:
##########
@@ -111,15 +111,15 @@ private Object getBeanByResourceAnnotation(SpringResource annotation) throws Ign
String beanName = annotation.resourceName();
Class<?> beanCls = annotation.resourceClass();
- boolean oneParamSet = !StringUtils.isEmpty(beanName) ^ beanCls != SpringResource.DEFAULT.class;
+ boolean oneParamSet = !ObjectUtils.isEmpty(beanName) ^ beanCls != SpringResource.DEFAULT.class;
Review Comment:
may be change for F.isEmpty() ?
##########
modules/clients/src/test/resources/jetty/router-jetty.xml:
##########
@@ -61,17 +61,5 @@
</Arg>
</Call>
- <Set name="handler">
- <New id="Handlers" class="org.eclipse.jetty.server.handler.HandlerCollection">
- <Set name="handlers">
- <Array type="org.eclipse.jetty.server.Handler">
- <Item>
- <New id="Contexts" class="org.eclipse.jetty.server.handler.ContextHandlerCollection"/>
Review Comment:
just check it once more
##########
modules/web/ignite-websphere-test/src/main/java/org/apache/ignite/webtest/TestJtaTxServlet.java:
##########
@@ -56,7 +56,7 @@ public class TestJtaTxServlet extends HttpServlet {
final IgniteCache<Integer, String> cache = ignite.cache("tx");
- TransactionManager tmMgr = TransactionManagerFactory.getTransactionManager();
+ UserTransaction tmMgr = (UserTransaction)new InitialContext().lookup("java:comp/UserTransaction");
Review Comment:
may be we can obtain context from HttpServlet ?
##########
modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GarHelloWorldTask.java:
##########
@@ -43,7 +43,8 @@ public class GarHelloWorldTask extends ComputeTaskSplitAdapter<String, String> {
/** {@inheritDoc} */
@Override public Collection<? extends ComputeJob> split(int gridSize, String arg) throws IgniteException {
// Create Spring context.
- AbstractBeanFactory fac = new XmlBeanFactory(
+ DefaultListableBeanFactory fac = new DefaultListableBeanFactory();
Review Comment:
check it plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28765 update Jetty [ignite]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on PR #13269:
URL: https://github.com/apache/ignite/pull/13269#issuecomment-4956203877
Implemented as part of ticket https://issues.apache.org/jira/browse/IGNITE-28588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org