You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2023/12/20 14:25:45 UTC
[PR] Proposal home with Paradox [incubator-pekko-site]
samueleresca opened a new pull request, #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47
The following PR is related to the following disscussions:
- https://github.com/apache/incubator-pekko-site/pull/4
- https://lists.apache.org/thread/fthn305vphk7l61gsldm2jyon7q7tz4w
Few notes:
- The styling is specific for the homepage. Everything else in the docs remains untouched.
- The actual content is mostly unchanged.
- In order to add a dedicated style to the page, I need to override the the `home.st` to include the styling.
I attach the visual results of the changes:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DO NOT MERGE] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1875126948
@pjfanning I'm proceeding today by resolving conflicts with https://github.com/apache/incubator-pekko-site/pull/54 and re-test the changes. I'm might send over the PR for another approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1867576240
I standby on merging this I want to proceed first with: https://github.com/apache/incubator-pekko-sbt-paradox/issues/84 (less moving piecies)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1877008415
Proceeding with the rebase in `asf-staging` and `asf-site` in the afternoon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1867574861
LGTM，good works.
For better:
could you test with `google translator`, no need for very strict testing,
because some developers are not native English speakers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1440495252
##########
src/main/paradox/index.md:
##########
@@ -1,13 +1,97 @@
-# Apache Pekko
-
-@@toc { depth=2 }
+---
+material.custom.page-stylesheet: assets/stylesheets/home.css
+---
@@@ index
-
- * [what is pekko](what-is-pekko.md)
+ * [samples](samples.md)
* [modules](modules.md)
* [download](download.md)
- * [samples](samples.md)
- * [how to contribute](how-to-contribute.md)
+ * [how-to-contribute](how-to-contribute.md)
+@@@
+
+@@@ div { .navigation}
+* @ref:[Samples](samples.md)
Review Comment:
samples and modules seem now to appear to in the index page
There are probably links to the old samples and modules pages so we should probably go to our other docs to check for links and repoint them to the index page. We should be planning in near future to remove the samples and modules pages. We could add .htaccess redirects to redirect those links to the index page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1440735880
##########
src/main/paradox/index.md:
##########
@@ -1,13 +1,97 @@
-# Apache Pekko
-
-@@toc { depth=2 }
+---
+material.custom.page-stylesheet: assets/stylesheets/home.css
+---
@@@ index
-
- * [what is pekko](what-is-pekko.md)
+ * [samples](samples.md)
* [modules](modules.md)
* [download](download.md)
- * [samples](samples.md)
- * [how to contribute](how-to-contribute.md)
+ * [how-to-contribute](how-to-contribute.md)
+@@@
+
+@@@ div { .navigation}
+* @ref:[Samples](samples.md)
Review Comment:
I think it makes sense to keep `samples.md` and `modules.md` as dedicated pages. I just noticed that using `## Modules` in the `index.md` plays funny with the navigation menu of the other pages.
I have updated `index.md` to declare the 2 subtitles "Sample" and "Modules" that do not interfere with the structure of the other pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1434002102
##########
build.sbt:
##########
@@ -19,7 +19,7 @@ enablePlugins(ParadoxPlugin, PekkoParadoxPlugin)
resolvers += Resolver.ApacheMavenSnapshotsRepo
-pekkoParadoxGithub := Some("https://github.com/apache/incubator-pekko-site")
+pekkoParadoxGithub := Some("https://github.com/apache/incubator-pekko")
Review Comment:
This link is used by the top-right GitHub link
It feels wrong to point to this repo(`incubator-pekko-site`) in the homepage of the project, as the actual core of Apache Pekko is `incubator-pekko` this repo is just for presentation purposes
Let me know your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1434933046
##########
build.sbt:
##########
@@ -19,7 +19,7 @@ enablePlugins(ParadoxPlugin, PekkoParadoxPlugin)
resolvers += Resolver.ApacheMavenSnapshotsRepo
-pekkoParadoxGithub := Some("https://github.com/apache/incubator-pekko-site")
+pekkoParadoxGithub := Some("https://github.com/apache/incubator-pekko")
Review Comment:
I guess with our other repos, our generated pages have a link at the bottom to make it easy for people to edit the page and submit a PR. These pages don't have that link. The edit link probably relies on this pekkoParadoxGithub property. I can live with using the wrong value for now (ie changing it to the pekko core repo instead of the pekko site repo).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1440730798
##########
content/assets/stylesheets/home.css:
##########
@@ -0,0 +1,193 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+h1 {
+ display: none;
+}
+
+h2 {
+ text-align: center;
+}
+
+.title {
+ margin-left: 20px;
+ max-width: 350px;
+ color: white;
+}
+
+.title > h2 {
+ font-size: 4.5rem;
+ text-align: left;
+}
+
+.md-typeset .title h2,
+.md-typeset ul li ul {
+ margin: 0
+}
+
+/* Hide sidebars in home */
+.md-sidebar--primary,
+.md-sidebar--secondary {
+ display: none;
+}
+
+.md-typeset .headerlink {
+ display: none;
+}
+
+.banner-logo p {
+ display: none;
+}
+
+/* Styling of the outer grid */
+.md-main__inner {
+ max-width: none;
+ height: 100%;
+ padding-top: 0;
+}
+
+.md-content {
+ margin: 0;
+}
+
+.md-content__inner {
+ margin: 0;
+ padding-top: 0;
+}
+
+.md-content__inner::before {
+ display: none;
+ content: none
+}
+
+.navigation {
+ background-color: #242323;
+ text-align: center;
+ padding: 15px 0;
+}
+
+.navigation a {
+ color: #fff;
+}
+
+.navigation ul {
+ list-style-type: none;
+ margin: 0;
+ padding: 0;
+ display: flex;
+ white-space: nowrap;
+ justify-content: center;
+ flex-wrap: wrap;
+}
+
+.navigation ul li {
+ display: inline-block;
+ margin: 5px 15px;
+}
+
+.hero {
+ display: flex;
+ justify-content: center;
+ align-content: center;
+ flex-wrap: wrap;
+ background: rgba(0, 0, 0, 0.895); /*linear-gradient(24deg, rgba(58, 159, 180, 0.8) 0%, rgba(253, 29, 29, 0.8) 50%, rgba(252, 176, 69, 0.8) 100%);*/
+ min-height: 500px;
+ column-gap: 60px;
+}
+
+.row {
+ margin: 20px;
+}
+
+.row a {
+ text-decoration: none;
+ color: #333;
+ margin: 0 5px;
+ flex-basis: 40%;
+}
+
+@media (max-width: 768px) {
+ .hero {
+ flex-direction: column;
+ align-items: center;
+ }
+
+ .title {
+ text-align: center;
+ margin: 20px 0;
+ }
+
+ .title h2 {
+ text-align: center;
+ }
+
+ .banner-logo {
+ display: none;
+ }
+}
+
+.banner-logo {
+ width: 100%;
+ background-image: url("../images/pekko_logo.png");
+ background-repeat: no-repeat;
+ background-size: contain;
+ background-position: center;
+ max-width: 280px;
+ min-height: 280px;
+}
+
+/* Styling Modules sections */
+.row > ul {
+ gap: 20px;
+ display: grid;
+ margin: 0 auto;
+ max-width: 769px;
+ text-align: center;
+ list-style-type: none;
+ grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
+}
+
+.row ul li {
+ margin: 0;
+ padding: 5px;
+ display: inline-block;
+}
+
+.row > ul > li {
+ background-color: #f0f0f0;
+ border-radius: 8px;
+ box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);
+ opacity: 1;
+ transition: opacity 0.3s ease-in-out;
+ cursor: default;
+}
+
+.row > ul > li:hover {
+ opacity: 0.8;
+}
+
+
+.md-header-nav__button.md-icon--home,
+.md-header-nav__button.md-logo {
+ display: block;
+}
+
+.md-header-nav__button.md-icon--menu {
+ display: none;
Review Comment:
Fair point, updating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1867576821
> LGTM，good works. For better: could you test with `google translator`, no need for very strict testing, because some developers are not native English speakers.
Good point, I will do a bit of testing on other langs before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1432846340
##########
README.md:
##########
@@ -6,9 +6,24 @@ This repo is used to publish the home page of the [Apache Pekko website](https:/
Anyone looking to help improve our module specific docs should look at the Git repos
(eg [incubator-pekko](https://github.com/apache/incubator-pekko)) for the modules.
-Typically, `sbt docs/paradoxBrowse` will build the docs and load them into your browser
-when they are ready. These repos have GitHub Action CI jobs that deploy the docs associated with
-those repos on a nightly basis.
There are some details about how to deploy the pages associated with this repo in the
[wiki](https://github.com/apache/incubator-pekko-site/wiki/Manual-Publishing).
+
+## Build
+
+The site is built using [Paradox](https://developer.lightbend.com/docs/paradox/current/).
Review Comment:
Could you move this section to before the bit about Manual Publishing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1432848212
##########
build.sbt:
##########
@@ -19,7 +19,7 @@ enablePlugins(ParadoxPlugin, PekkoParadoxPlugin)
resolvers += Resolver.ApacheMavenSnapshotsRepo
-pekkoParadoxGithub := Some("https://github.com/apache/incubator-pekko-site")
+pekkoParadoxGithub := Some("https://github.com/apache/incubator-pekko")
Review Comment:
feels wrong to link to wrong repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1432846340
##########
README.md:
##########
@@ -6,9 +6,24 @@ This repo is used to publish the home page of the [Apache Pekko website](https:/
Anyone looking to help improve our module specific docs should look at the Git repos
(eg [incubator-pekko](https://github.com/apache/incubator-pekko)) for the modules.
-Typically, `sbt docs/paradoxBrowse` will build the docs and load them into your browser
-when they are ready. These repos have GitHub Action CI jobs that deploy the docs associated with
-those repos on a nightly basis.
There are some details about how to deploy the pages associated with this repo in the
[wiki](https://github.com/apache/incubator-pekko-site/wiki/Manual-Publishing).
+
+## Build
+
+The site is built using [Paradox](https://developer.lightbend.com/docs/paradox/current/).
Review Comment:
Could you link to this wiki page as well?
https://github.com/apache/incubator-pekko-site/wiki/Manual-Publishing
Feel free to add extra details to that wiki page if you feel it lacks info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1866149547
> copying this non ASF, non Apache licensed code to here means we need to change the LICENSE and NOTICE for this repo.
I might have found a better approach to this, see: https://github.com/apache/incubator-pekko-sbt-paradox/pull/85. The change would allow to have a stylesheet dedicated to the page on top of the common theme stylesheet.
If this approach is successful we don't need to override `home.st` at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DO NOT MERGE] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#issuecomment-1875228164
> LGTM，good works. For better: could you test with `google translator`, no need for very strict testing, because some developers are not native English speakers.
@laglangyue I verified the page with google transltor localized in multiple lang. The spacing and the menu respond correctly. If you have any specific lang you want to test please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47#discussion_r1440487730
##########
content/assets/stylesheets/home.css:
##########
@@ -0,0 +1,193 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+h1 {
+ display: none;
+}
+
+h2 {
+ text-align: center;
+}
+
+.title {
+ margin-left: 20px;
+ max-width: 350px;
+ color: white;
+}
+
+.title > h2 {
+ font-size: 4.5rem;
+ text-align: left;
+}
+
+.md-typeset .title h2,
+.md-typeset ul li ul {
+ margin: 0
+}
+
+/* Hide sidebars in home */
+.md-sidebar--primary,
+.md-sidebar--secondary {
+ display: none;
+}
+
+.md-typeset .headerlink {
+ display: none;
+}
+
+.banner-logo p {
+ display: none;
+}
+
+/* Styling of the outer grid */
+.md-main__inner {
+ max-width: none;
+ height: 100%;
+ padding-top: 0;
+}
+
+.md-content {
+ margin: 0;
+}
+
+.md-content__inner {
+ margin: 0;
+ padding-top: 0;
+}
+
+.md-content__inner::before {
+ display: none;
+ content: none
+}
+
+.navigation {
+ background-color: #242323;
+ text-align: center;
+ padding: 15px 0;
+}
+
+.navigation a {
+ color: #fff;
+}
+
+.navigation ul {
+ list-style-type: none;
+ margin: 0;
+ padding: 0;
+ display: flex;
+ white-space: nowrap;
+ justify-content: center;
+ flex-wrap: wrap;
+}
+
+.navigation ul li {
+ display: inline-block;
+ margin: 5px 15px;
+}
+
+.hero {
+ display: flex;
+ justify-content: center;
+ align-content: center;
+ flex-wrap: wrap;
+ background: rgba(0, 0, 0, 0.895); /*linear-gradient(24deg, rgba(58, 159, 180, 0.8) 0%, rgba(253, 29, 29, 0.8) 50%, rgba(252, 176, 69, 0.8) 100%);*/
+ min-height: 500px;
+ column-gap: 60px;
+}
+
+.row {
+ margin: 20px;
+}
+
+.row a {
+ text-decoration: none;
+ color: #333;
+ margin: 0 5px;
+ flex-basis: 40%;
+}
+
+@media (max-width: 768px) {
+ .hero {
+ flex-direction: column;
+ align-items: center;
+ }
+
+ .title {
+ text-align: center;
+ margin: 20px 0;
+ }
+
+ .title h2 {
+ text-align: center;
+ }
+
+ .banner-logo {
+ display: none;
+ }
+}
+
+.banner-logo {
+ width: 100%;
+ background-image: url("../images/pekko_logo.png");
+ background-repeat: no-repeat;
+ background-size: contain;
+ background-position: center;
+ max-width: 280px;
+ min-height: 280px;
+}
+
+/* Styling Modules sections */
+.row > ul {
+ gap: 20px;
+ display: grid;
+ margin: 0 auto;
+ max-width: 769px;
+ text-align: center;
+ list-style-type: none;
+ grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
+}
+
+.row ul li {
+ margin: 0;
+ padding: 5px;
+ display: inline-block;
+}
+
+.row > ul > li {
+ background-color: #f0f0f0;
+ border-radius: 8px;
+ box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);
+ opacity: 1;
+ transition: opacity 0.3s ease-in-out;
+ cursor: default;
+}
+
+.row > ul > li:hover {
+ opacity: 0.8;
+}
+
+
+.md-header-nav__button.md-icon--home,
+.md-header-nav__button.md-logo {
+ display: block;
+}
+
+.md-header-nav__button.md-icon--menu {
+ display: none;
Review Comment:
minor nit but you can add a new line at EOF?
##########
content/assets/stylesheets/home.css:
##########
@@ -0,0 +1,193 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+h1 {
+ display: none;
+}
+
+h2 {
+ text-align: center;
+}
+
+.title {
+ margin-left: 20px;
+ max-width: 350px;
+ color: white;
+}
+
+.title > h2 {
+ font-size: 4.5rem;
+ text-align: left;
+}
+
+.md-typeset .title h2,
+.md-typeset ul li ul {
+ margin: 0
+}
+
+/* Hide sidebars in home */
+.md-sidebar--primary,
+.md-sidebar--secondary {
+ display: none;
+}
+
+.md-typeset .headerlink {
+ display: none;
+}
+
+.banner-logo p {
+ display: none;
+}
+
+/* Styling of the outer grid */
+.md-main__inner {
+ max-width: none;
+ height: 100%;
+ padding-top: 0;
+}
+
+.md-content {
+ margin: 0;
+}
+
+.md-content__inner {
+ margin: 0;
+ padding-top: 0;
+}
+
+.md-content__inner::before {
+ display: none;
+ content: none
+}
+
+.navigation {
+ background-color: #242323;
+ text-align: center;
+ padding: 15px 0;
+}
+
+.navigation a {
+ color: #fff;
+}
+
+.navigation ul {
+ list-style-type: none;
+ margin: 0;
+ padding: 0;
+ display: flex;
+ white-space: nowrap;
+ justify-content: center;
+ flex-wrap: wrap;
+}
+
+.navigation ul li {
+ display: inline-block;
+ margin: 5px 15px;
+}
+
+.hero {
+ display: flex;
+ justify-content: center;
+ align-content: center;
+ flex-wrap: wrap;
+ background: rgba(0, 0, 0, 0.895); /*linear-gradient(24deg, rgba(58, 159, 180, 0.8) 0%, rgba(253, 29, 29, 0.8) 50%, rgba(252, 176, 69, 0.8) 100%);*/
+ min-height: 500px;
+ column-gap: 60px;
+}
+
+.row {
+ margin: 20px;
+}
+
+.row a {
+ text-decoration: none;
+ color: #333;
+ margin: 0 5px;
+ flex-basis: 40%;
+}
+
+@media (max-width: 768px) {
+ .hero {
+ flex-direction: column;
+ align-items: center;
+ }
+
+ .title {
+ text-align: center;
+ margin: 20px 0;
+ }
+
+ .title h2 {
+ text-align: center;
+ }
+
+ .banner-logo {
+ display: none;
+ }
+}
+
+.banner-logo {
+ width: 100%;
+ background-image: url("../images/pekko_logo.png");
+ background-repeat: no-repeat;
+ background-size: contain;
+ background-position: center;
+ max-width: 280px;
+ min-height: 280px;
+}
+
+/* Styling Modules sections */
+.row > ul {
+ gap: 20px;
+ display: grid;
+ margin: 0 auto;
+ max-width: 769px;
+ text-align: center;
+ list-style-type: none;
+ grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
+}
+
+.row ul li {
+ margin: 0;
+ padding: 5px;
+ display: inline-block;
+}
+
+.row > ul > li {
+ background-color: #f0f0f0;
+ border-radius: 8px;
+ box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);
+ opacity: 1;
+ transition: opacity 0.3s ease-in-out;
+ cursor: default;
+}
+
+.row > ul > li:hover {
+ opacity: 0.8;
+}
+
+
+.md-header-nav__button.md-icon--home,
+.md-header-nav__button.md-logo {
+ display: block;
+}
+
+.md-header-nav__button.md-icon--menu {
+ display: none;
Review Comment:
minor nit but can you add a new line at EOF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Proposal home with Paradox [incubator-pekko-site]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca merged PR #47:
URL: https://github.com/apache/incubator-pekko-site/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org