You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2016/07/13 08:49:54 UTC
[jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/300
-- Commit Summary --
* [azure-arm] add supports to port ranges to addNetworkSecurityGroup
-- File Changes --
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/util/DeploymentTemplateBuilder.java (90)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/300.patch
https://github.com/jclouds/jclouds-labs/pull/300.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -323,6 +326,43 @@ private void addNetworkSecurityGroup() {
>
> }
>
> + // Helper function for simplifying an array of ports to a list of ranges FirewallOptions expects.
> + public static List<String> simplifyPorts(int[] ports){
Add the corresponding unit tests that verify this method works for the different types of input ports: isolated ones, contiguous, etc.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300/files/bbfa9982d1d1f2674fa45fd24ba89db1f39f0831#r70711516
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -323,6 +326,43 @@ private void addNetworkSecurityGroup() {
>
> }
>
> + // Helper function for simplifying an array of ports to a list of ranges FirewallOptions expects.
> + public static List<String> simplifyPorts(int[] ports){
> + if ((ports == null) || (ports.length == 0)) {
> + return null;
This should never happen at this point, as it is already validated before. Consider it a precondition of this method and better throw an `IllegalArgumentException`. Otherwise you must add a check in the caller to verify that the returned value is not null, to avoid NPEs.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300/files/bbfa9982d1d1f2674fa45fd24ba89db1f39f0831#r70711130
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Ignasi Barrera <no...@github.com>.
+1!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300#issuecomment-232792909
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Andrea Turli <no...@github.com>.
@andreaturli pushed 1 commit.
fbe58c1 add unit tests
---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300/files/bbfa9982d1d1f2674fa45fd24ba89db1f39f0831..fbe58c1aad4aab0126a117154d3479cc9ff779f5
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Andrea Turli <no...@github.com>.
Closed #300.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300#event-724149884
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Andrea Turli <no...@github.com>.
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/b975be5e)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300#issuecomment-232909926
Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to
addNetworkSecurityGroup (#300)
Posted by Andrea Turli <no...@github.com>.
thanks @nacx, merging now
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/300#issuecomment-232898315