You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@synapse.apache.org by ve...@apache.org on 2009/05/10 14:45:29 UTC

svn commit: r773333 - /synapse/trunk/java/modules/transports/core/vfs/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java

Author: veithen
Date: Sun May 10 12:45:28 2009
New Revision: 773333

URL: http://svn.apache.org/viewvc?rev=773333&view=rev
Log:
SYNAPSE-544: Restored the change in r759708 (temporarily reverted in r760799), so that the VFS transport sender triggers an error when used with the wrong message exchange pattern. As described in SYNAPSE-543, it is actually the sample 254 that is incorrect, not the change in r759708.

Modified:
    synapse/trunk/java/modules/transports/core/vfs/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java

Modified: synapse/trunk/java/modules/transports/core/vfs/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java
URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/transports/core/vfs/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java?rev=773333&r1=773332&r2=773333&view=diff
==============================================================================
--- synapse/trunk/java/modules/transports/core/vfs/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java (original)
+++ synapse/trunk/java/modules/transports/core/vfs/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java Sun May 10 12:45:28 2009
@@ -79,16 +79,10 @@
     public void sendMessage(MessageContext msgCtx, String targetAddress,
         OutTransportInfo outTransportInfo) throws AxisFault {
 
-        // TODO: this check is too strict and breaks sample 254
-        // Need to check
-        //  - why this isn't detected by the unit tests
-        //  - why this works with JMS (the JMS transport sender uses the same method to determine
-        //    whether to wait for a response; if this change breaks sample 254, one would also
-        //    expect problems with sample 254 when substituting VFS by JMS)
-//        if (waitForSynchronousResponse(msgCtx)) {
-//            throw new AxisFault("The VFS transport doesn't support synchronous responses. " +
-//            		"Please use the appropriate (out only) message exchange pattern.");
-//        }
+        if (waitForSynchronousResponse(msgCtx)) {
+            throw new AxisFault("The VFS transport doesn't support synchronous responses. " +
+            		"Please use the appropriate (out only) message exchange pattern.");
+        }
 
         VFSOutTransportInfo vfsOutInfo = null;