You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/02 17:40:11 UTC
[GitHub] [cassandra] josh-mckenzie opened a new pull request, #1965: CASSANDRA-17679-Fix BootstrapTest failure on vnodes
josh-mckenzie opened a new pull request, #1965:
URL: https://github.com/apache/cassandra/pull/1965
Fix Bootstrap test failure; RTE catch was swallowing the AssumptionViolatedException that we normally check to ensure a test doesn't run in a vnode config if the test explicitly calls to be run without it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] josh-mckenzie closed pull request #1965: CASSANDRA-17679-Fix BootstrapTest failure on vnodes
Posted by GitBox <gi...@apache.org>.
josh-mckenzie closed pull request #1965: CASSANDRA-17679-Fix BootstrapTest failure on vnodes
URL: https://github.com/apache/cassandra/pull/1965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #1965: CASSANDRA-17679-Fix BootstrapTest failure on vnodes
Posted by GitBox <gi...@apache.org>.
dcapwell commented on code in PR #1965:
URL: https://github.com/apache/cassandra/pull/1965#discussion_r1012107377
##########
test/distributed/org/apache/cassandra/distributed/test/ring/BootstrapTest.java:
##########
@@ -196,6 +197,12 @@ public void bootstrapUnspecifiedFailsOnResumeTest() throws Throwable
bootstrap()),
newInstance.config().num());
}
+ catch (AssumptionViolatedException ave)
+ {
+ // We get an AssumptionViolatedException if we're in a test job configured w/vnodes
+ if (ave.getMessage().contains("vnode is requested but not supported"))
Review Comment:
remove this check, the type is very explicit "junit ignore this test", you trying to ignore that isn't good and will be brittle.
Also, add `throw ave` so it actually is skipped and not passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org