You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/18 01:36:05 UTC

[GitHub] [hbase] ndimiduk opened a new pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

ndimiduk opened a new pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk merged pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r369206224
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
 
 Review comment:
   Yes I think we aught... I thought it was included here. I need to review my IDE configs. Will be back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r369207415
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
+        <entry key="copy-libs" value="false" />
+        <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
+        <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
+        <entry key="scan-before-checkin" value="false" />
+        <entry key="scanscope" value="JavaOnly" />
 
 Review comment:
   IIRC, our POM is configured to ignore tests at the moment. I think we can/should be more strict, but that's not what we're starting from. Maybe it's worth discussing with @busbey and @HorizonNet ; I think those two have done the most work with Checkstyle, as far as I am aware.
   
   Given we don't error out the build on violations, I think it would be fine to cover the test code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r368198213
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
 
 Review comment:
   Shouldn't we include the path for active configuration? Something like below, otherwise how does it hook up with our check style configuration? Something like below..
   
   ```
   <?xml version="1.0" encoding="UTF-8"?>
   <project version="4">
     <component name="CheckStyle-IDEA">
       <option name="configuration">
         <map>
           <entry key="active-configuration" value="LOCAL_FILE:$PROJECT_DIR$/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml:hbase" />
           <entry key="checkstyle-version" value="8.10.1" />
           <entry key="copy-libs" value="false" />
           <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
           <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
           <entry key="location-2" value="LOCAL_FILE:$PROJECT_DIR$/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml:hbase" />
           <entry key="scan-before-checkin" value="false" />
           <entry key="scanscope" value="JavaOnlyWithTests" />
           <entry key="suppress-errors" value="false" />
         </map>
       </option>
     </component>
   </project>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r368198141
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
+        <entry key="copy-libs" value="false" />
+        <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
+        <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
+        <entry key="scan-before-checkin" value="false" />
+        <entry key="scanscope" value="JavaOnly" />
 
 Review comment:
   I think this should be "JavaOnlyWithTests".. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] jshiell edited a comment on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
jshiell edited a comment on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-575995046
 
 
   > There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?
   
   I'm afraid not, and no plans to add it at present. There's no abstraction that IDEA provides for this, so we'd need to implement code for each build system - Maven at least is just XML, but Gradle is an entirely different kettle of fish. I won't even think about SBT ... 😄 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r369239072
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
+        <entry key="copy-libs" value="false" />
+        <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
+        <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
+        <entry key="scan-before-checkin" value="false" />
+        <entry key="scanscope" value="JavaOnly" />
 
 Review comment:
   > IRC, our POM is configured to ignore tests at the moment. 
   
   Not totally sure about this. Here [1] is one instance where a test file is flagged by the checkstyle bot.
   [1] https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1039/2/artifact/out/diff-checkstyle-hbase-server.txt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-578375243
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  6s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 58s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 19s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 37s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m  6s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m  5s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 32s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 24s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 24s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   2m 29s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  3s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedjars  |   5m  2s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  17m 33s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   2m 53s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 211m 53s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 36s |  The patch does not generate ASF License warnings.  |
   |  |   | 277m  7s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1064 |
   | Optional Tests | dupname asflicense checkstyle xml javac javadoc unit shadedjars hadoopcheck compile |
   | uname | Linux 6d51f4c309aa 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1064/out/precommit/personality/provided.sh |
   | git revision | master / 753cc99814 |
   | Default Java | 1.8.0_181 |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/artifact/out/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/testReport/ |
   | Max. process+thread count | 5136 (vs. ulimit of 10000) |
   | modules | C: . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-575855194
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 28s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 54s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   2m 10s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 20s |  The patch does not generate ASF License warnings.  |
   |  |   |  16m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1064 |
   | Optional Tests | dupname asflicense checkstyle xml |
   | uname | Linux 49ff86982143 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1064/out/precommit/personality/provided.sh |
   | git revision | master / 70c8a5d939 |
   | Max. process+thread count | 96 (vs. ulimit of 10000) |
   | modules | C: . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1064/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-576353135
 
 
   I tried the patch. Before applying, I was getting the below when I sync'd the checkstyle versions between hbase and intellij...
   
   
   
   1/20/20
   8:23 AM	The Checkstyle rules file could not be parsed.
   				LineLength is not allowed as a child in Checker
   				The file has been blacklisted for 60s.
   
   8:23 AM	Unexpected Exception Caught
   				The scan failed due to an exception: Could not create checker
   				org.infernus.idea.checkstyle.exception.CheckStylePluginException: Could not create checker
   				at org.infernus.idea.checkstyle.checker.ScanFiles.lambda$checkFiles$8(ScanFiles.java:198)
   				at java.util.Optional.orElseThrow(Optional.java:290)
   				at org.infernus.idea.checkstyle.checker.ScanFiles.checkFiles(ScanFiles.java:198)
   				at org.infernus.idea.checkstyle.checker.ScanFiles.processFilesForModuleInfoAndScan(ScanFiles.java:156)
   				at org.infernus.idea.checkstyle.checker.ScanFiles.call(ScanFiles.java:78)
   				at org.infernus.idea.checkstyle.checker.ScanFiles.call(ScanFiles.java:32)
   				at com.intellij.openapi.application.impl.ApplicationImpl$2.call(ApplicationImpl.java:337)
   				at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   				at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1... (show balloon)
   
   
   With this patch applied, I now get style complaints that make sense.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-575853591
 
 
   There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] HorizonNet commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r369211457
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
+        <entry key="copy-libs" value="false" />
+        <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
+        <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
+        <entry key="scan-before-checkin" value="false" />
+        <entry key="scanscope" value="JavaOnly" />
 
 Review comment:
   We are less strict with some rules when it comes to tests, but they are still scanned by Checkstyle. With that it should be `JavaOnlyWithTests`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-578342475
 
 
   > > There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?
   > 
   > I'm afraid not, and no plans to add it at present. There's no abstraction that IDEA provides for this, so we'd need to implement code for each build system - Maven at least is just XML, but Gradle is an entirely different kettle of fish. I won't even think about SBT ... 😄
   
   Even "just xml" is a bit of a warren. Thanks for checking in, @jshiell !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] jshiell commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
jshiell commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-575995046
 
 
   > There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?
   
   I'm afraid not, and no plans to add it at present. There's no abstraction that IDEA provides for this, so we'd need to implement code for each build system - Maven at least is just XML, but Gradle is an entirely different kettle of fish. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] jshiell edited a comment on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
jshiell edited a comment on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#issuecomment-575995046
 
 
   > There's no way that I know of for keeping the checkstyle version specified here in sync with the version defined in our pom. Any thoughts here @jshiell ?
   
   I'm afraid not, and no plans to add it at present. There's no abstraction that IDEA provides for this, so we'd need to implement code for each build system - Maven at least is just XML, but Gradle is an entirely different kettle of fish. I won't even think about SBT ... :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration

Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r368198213
 
 

 ##########
 File path: .idea/checkstyle-idea.xml
 ##########
 @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="CheckStyle-IDEA">
+    <option name="configuration">
+      <map>
+        <entry key="checkstyle-version" value="8.28" />
 
 Review comment:
   Shouldn't we include the path for active configuration? Something like below, otherwise how does it hook up with our check style plugin? Something like below..
   
   ```
   <?xml version="1.0" encoding="UTF-8"?>
   <project version="4">
     <component name="CheckStyle-IDEA">
       <option name="configuration">
         <map>
           <entry key="active-configuration" value="LOCAL_FILE:$PROJECT_DIR$/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml:hbase" />
           <entry key="checkstyle-version" value="8.10.1" />
           <entry key="copy-libs" value="false" />
           <entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
           <entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
           <entry key="location-2" value="LOCAL_FILE:$PROJECT_DIR$/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml:hbase" />
           <entry key="scan-before-checkin" value="false" />
           <entry key="scanscope" value="JavaOnlyWithTests" />
           <entry key="suppress-errors" value="false" />
         </map>
       </option>
     </component>
   </project>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services