You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/11 06:27:04 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

dongjoon-hyun opened a new pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187
 
 
   …
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612379127
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121123/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612350643
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121122/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612366069
 
 
   BTW, for reviewers, during looking at this, I investigated the other sources. The other sources look okay because they don't have risky remote invocation like `BlockManagerSource`.
   - DAGSchedulerSource
   - JVMCPUSource
   - ExecutorMetricsSource
   - ExecutorAllocationManagerSource
   - AppStatusSource
   - ExternalShuffleServiceSource
   - MasterSource
   - WorkerSource
   - ExecutorSource
   - PluginMetricsSource
   - CodegenMetrics
   - HiveCatalogMetrics
   - LongAccumulatorSource
   - DoubleAccumulatorSource
   - LiveListenerBusMetrics
   - ApplicationSource
   - MetricsReporter
   - StreamingSource

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612390273
 
 
   **[Test build #121126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121126/testReport)** for PR 28187 at commit [`82e46a8`](https://github.com/apache/spark/commit/82e46a868fabb00a0e2f6cb140d22d4dd35c33e5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407035428
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   Sorry, but I don't think so. In your example, `query locations of blockIds` is just do mocking instead of testing.
   ```
   test("query locations of blockIds") {
       val mockBlockManagerMaster = mock(classOf[BlockManagerMaster])
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407026183
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
 ##########
 @@ -167,10 +167,12 @@ class BlockManagerMaster(
    * amount of remaining memory.
    */
   def getMemoryStatus: Map[BlockManagerId, (Long, Long)] = {
+    if (driverEndpoint == null) return Map.empty
 
 Review comment:
   Although only `getStorageStatus` is used, I added the preventive code into `getMemoryStatus` together because it can be used, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407035678
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   Ok, fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407033945
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   I considered that, but BlockManagerSuite looks misleading to me because this is `BlockManagerManger`. If there is a more broader suite, it could be a candidate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612364607
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407035738
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   Also, `BlockManagerSuite` is already large with 1805 lines. In general, we had better have a proper UT case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612360535
 
 
   Thank you for reviewing and approval. Yes, it's possible, but the stop sequence has been fixed since `Apache Spark 0.8.0-incubating`. There might exist a risk because some user sink classes depend on that behavior. In this PR, I wanted to focus on this narrow one safely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612366328
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612366791
 
 
   Thank you for review, @Ngone51 . 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407026183
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
 ##########
 @@ -167,10 +167,12 @@ class BlockManagerMaster(
    * amount of remaining memory.
    */
   def getMemoryStatus: Map[BlockManagerId, (Long, Long)] = {
+    if (driverEndpoint == null) return Map.empty
 
 Review comment:
   Although only `getStorageStatus` is used, I added the preventive code into `getMemoryStatus` together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612351660
 
 
   **[Test build #121123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121123/testReport)** for PR 28187 at commit [`438b78b`](https://github.com/apache/spark/commit/438b78b850767dc76efe324cff2243f758a181f5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612364612
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25814/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612379121
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612360535
 
 
   Thank you for reviewing and approval. Yes, it's possible, but the stop sequence has been fixed since `Apache Spark 0.8.0-incubating`. There might exist a risk because some user sink classes depend on that behavior. So, in this PR, I wanted to focus on this narrow one as a safer solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612345367
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612350639
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612390666
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121126/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612350639
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612390665
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612379121
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612345367
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407026183
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
 ##########
 @@ -167,10 +167,12 @@ class BlockManagerMaster(
    * amount of remaining memory.
    */
   def getMemoryStatus: Map[BlockManagerId, (Long, Long)] = {
+    if (driverEndpoint == null) return Map.empty
 
 Review comment:
   Although only `getStorageStatus` is used, I added the preventive code into `getMemoryStatus` together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612366069
 
 
   BTW, for reviewers, during looking at this, I investigated the other sources. The other sources look okay because they don't have remote invocation like `BlockManagerSource`.
   - DAGSchedulerSource
   - JVMCPUSource
   - ExecutorMetricsSource
   - ExecutorAllocationManagerSource
   - AppStatusSource
   - ExternalShuffleServiceSource
   - MasterSource
   - WorkerSource
   - ExecutorSource
   - PluginMetricsSource
   - CodegenMetrics
   - HiveCatalogMetrics
   - LongAccumulatorSource
   - DoubleAccumulatorSource
   - LiveListenerBusMetrics
   - ApplicationSource
   - MetricsReporter
   - StreamingSource

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612364612
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25814/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612350867
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612446376
 
 
   Thank you. Merged to master/3.0/2.4.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612364607
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612348663
 
 
   Hi, @maropu .
   Could you review this PR please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612345101
 
 
   **[Test build #121122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121122/testReport)** for PR 28187 at commit [`438b78b`](https://github.com/apache/spark/commit/438b78b850767dc76efe324cff2243f758a181f5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612350643
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121122/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612351954
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612360535
 
 
   It's possible, but the stop sequence has been fixed since `Apache Spark 0.8.0-incubating`. There might be a risk because some user sink classes depend on that behavior. In this PR, I wanted to focus on this narrow one safely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612351958
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25811/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612364401
 
 
   **[Test build #121126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121126/testReport)** for PR 28187 at commit [`82e46a8`](https://github.com/apache/spark/commit/82e46a868fabb00a0e2f6cb140d22d4dd35c33e5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612353325
 
 
   The fix itself is straight-forward and looks fine to me. Btw, (Just a question); couldn't we stop `MetricsSystem`  before stopping `BlockManagerMaster` even if  it depends on `BlockManagerMaster`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612364401
 
 
   **[Test build #121126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121126/testReport)** for PR 28187 at commit [`82e46a8`](https://github.com/apache/spark/commit/82e46a868fabb00a0e2f6cb140d22d4dd35c33e5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612345101
 
 
   **[Test build #121122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121122/testReport)** for PR 28187 at commit [`438b78b`](https://github.com/apache/spark/commit/438b78b850767dc76efe324cff2243f758a181f5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612345374
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25810/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612390665
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612350589
 
 
   **[Test build #121122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121122/testReport)** for PR 28187 at commit [`438b78b`](https://github.com/apache/spark/commit/438b78b850767dc76efe324cff2243f758a181f5).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407033578
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   Add tests to `BlockManagerSuite` should be enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407033628
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
+
+  test("getMemoryStatus should not fail after BlockManagerMaster stops") {
+    val bmm = new BlockManagerMaster(null, null, new SparkConf, true)
+    assertTrue(bmm.getMemoryStatus.isEmpty)
+  }
+
+  test("getStorageStatus should not fail after BlockManagerMaster stops") {
 
 Review comment:
   Could you attach JIRA id for the test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612360535
 
 
   Thank you for reviewing and approval. Yes, it's possible, but the stop sequence has been fixed since `Apache Spark 0.8.0-incubating`. There might exist a risk because some user sink classes depend on that behavior. So, in this PR, I wanted to focus on this narrow one safely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407033945
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   Yes. I considered that, but BlockManagerSuite looks misleading to me because this is `BlockManagerManger`. If there is a more broader suite, it could be a candidate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612351660
 
 
   **[Test build #121123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121123/testReport)** for PR 28187 at commit [`438b78b`](https://github.com/apache/spark/commit/438b78b850767dc76efe324cff2243f758a181f5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612351954
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407033954
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
+
+  test("getMemoryStatus should not fail after BlockManagerMaster stops") {
+    val bmm = new BlockManagerMaster(null, null, new SparkConf, true)
+    assertTrue(bmm.getMemoryStatus.isEmpty)
+  }
+
+  test("getStorageStatus should not fail after BlockManagerMaster stops") {
 
 Review comment:
   Sure!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612390666
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121126/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612378765
 
 
   **[Test build #121123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121123/testReport)** for PR 28187 at commit [`438b78b`](https://github.com/apache/spark/commit/438b78b850767dc76efe324cff2243f758a181f5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612379127
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121123/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612360535
 
 
   Thank you for reviewing and approval. Yes, it's possible, but the stop sequence has been fixed since `Apache Spark 0.8.0-incubating`. There might be a risk because some user sink classes depend on that behavior. In this PR, I wanted to focus on this narrow one safely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612345374
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25810/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#issuecomment-612351958
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25811/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407035050
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerMasterSuite.scala
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.junit.Assert.assertTrue
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+
+class BlockManagerMasterSuite extends SparkFunSuite {
 
 Review comment:
   I actually think it should be ok because we always test `BlockManagerMaster` together with `BlockManager`. And there're already some tests which test `BlockManagerMaster` only, e.g.
   
   - `query locations of blockIds`
   
   - `SPARK-30594: Do not post SparkListenerBlockUpdated when updateBlockInfo returns false`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org